fix: implement capture-avoiding substitution for De Bruijn indices#554
Closed
yyhrnk wants to merge 1 commit intonexus-xyz:mainfrom
Closed
fix: implement capture-avoiding substitution for De Bruijn indices#554yyhrnk wants to merge 1 commit intonexus-xyz:mainfrom
yyhrnk wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Thanks for the PR. I'm going to pass: this is just some toy demo code, and I don't want it to fall out of consistency with the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the ad-hoc substitution with the standard De Bruijn algorithm using shift/subst. This prevents variable capture under lambdas and ensures correct beta-reduction. The new step applies beta as shift(-1, 0, subst(0, shift(1, 0, arg), body)), following the canonical formulation. Existing simple assertions continue to pass while complex terms now reduce correctly.