refactor(vm): remove redundant clone in add_fixed macro#563
Closed
Aleksandr1732 wants to merge 1 commit intonexus-xyz:mainfrom
Closed
refactor(vm): remove redundant clone in add_fixed macro#563Aleksandr1732 wants to merge 1 commit intonexus-xyz:mainfrom
Aleksandr1732 wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
binadamu-isiyoonekana
pushed a commit
to binadamu-isiyoonekana/nexus-zkvm
that referenced
this pull request
Jan 3, 2026
* A lot of initial work towards improved benchmarks. * Add 65536 trace length bench. * Remove grapher. * Finish fixing up printing. * Formatting. * Clippy. * Fixes. * Align iterations. * Make csv export happen.
Contributor
|
@Aleksandr1732 this is not redundant, as you see removing this clone leads to tests failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary
.clone()call onRange<u32>in theadd_fixed!macro.