Skip to content

refactor(runtime): derive Clone for KeccakState instead of manual impl#566

Closed
0xxFloki wants to merge 1 commit intonexus-xyz:mainfrom
0xxFloki:patch-3
Closed

refactor(runtime): derive Clone for KeccakState instead of manual impl#566
0xxFloki wants to merge 1 commit intonexus-xyz:mainfrom
0xxFloki:patch-3

Conversation

@0xxFloki
Copy link

Removes redundant manual Clone implementation for KeccakState<P> by using #[derive(Clone)] instead.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@0xxFloki
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

binadamu-isiyoonekana pushed a commit to binadamu-isiyoonekana/nexus-zkvm that referenced this pull request Jan 3, 2026
* Avoid repetitive definitions of is_alu_imm_no_shift

* Fix definition of is_type_i
@sjudson sjudson requested a review from slumber January 5, 2026 13:32
@slumber
Copy link
Contributor

slumber commented Jan 5, 2026

This code is a part of forked tiny_keccak, I would suggest against modifying it.

Original implementation is manual probably to avoid putting bounds on generic parameter.

@slumber slumber closed this Jan 5, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants