Skip to content

Commit 3cdec0a

Browse files
committed
adjusted paramet names and help text, per review
1 parent d62d8b9 commit 3cdec0a

4 files changed

Lines changed: 7 additions & 6 deletions

File tree

conf/test_microbial.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ params {
4444

4545
// BAM filtering
4646
deduplication_tool = "dedup"
47-
deduplication_mergejobs = true
47+
deduplication_skipregionsplit = true
4848
run_bamfiltering = true
4949
bamfiltering_minreadlength = 30
5050
bamfiltering_mappingquality = 37

nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ params {
199199

200200
// Deduplication options
201201
skip_deduplication = false
202-
deduplication_mergejobs = false
202+
deduplication_skipregionsplit = false
203203
deduplication_tool = 'markduplicates'
204204

205205
// Qualimap

nextflow_schema.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1002,10 +1002,11 @@
10021002
"description": "Specify to skip the removal of PCR duplicates.",
10031003
"fa_icon": "fas fa-forward"
10041004
},
1005-
"deduplication_mergejobs": {
1005+
"deduplication_skipregionsplit": {
10061006
"type": "boolean",
10071007
"description": "Specify to run deduplicaiton without splitting bams by contig (default behavior).",
1008-
"fa_icon": "fas fa-forward"
1008+
"fa_icon": "fas fa-forward",
1009+
"help_text": "Run deduplication steps bam-by-bam rather than contig-by-contig for each bam file. This reduces the total number of jobs submitted to a cluster, but increases the computational runtime. If you use a shared cluster with limited resources, running many low-resource jobs can slow down the overall runtime of eager due to scheduling constraints.\nAlso applicable for poor-quality reference genomes."
10091010
},
10101011
"deduplication_tool": {
10111012
"type": "string",

subworkflows/local/deduplicate.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ workflow DEDUPLICATE {
2929
addNewMetaFromAttributes( it, "id" , "reference" , false )
3030
}
3131

32-
if ( params.deduplication_mergejobs ) {
32+
if ( params.deduplication_skipregionsplit ) {
3333

3434
// No splitting of .bam files by contig, deduplicate all in one
3535
input_for_deduplication = ch_bam_bai
@@ -110,7 +110,7 @@ workflow DEDUPLICATE {
110110
ch_dedupped_bam = DEDUP.out.bam
111111
}
112112

113-
if ( params.deduplication_mergejobs ) {
113+
if ( params.deduplication_skipregionsplit ) {
114114

115115
// Bams were never split by region, so bypass of re-merging
116116
ch_input_for_samtools_sort_dedupped = ch_dedupped_bam

0 commit comments

Comments
 (0)