Skip to content

fix variable naming#63

Merged
CaroAMN merged 2 commits into
nf-core:devfrom
CaroAMN:patch-release-1.0.1
May 18, 2026
Merged

fix variable naming#63
CaroAMN merged 2 commits into
nf-core:devfrom
CaroAMN:patch-release-1.0.1

Conversation

@CaroAMN
Copy link
Copy Markdown
Collaborator

@CaroAMN CaroAMN commented May 15, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/lsmquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
    fix for :
ERROR    Command 'nextflow inspect -format json -profile                        
         singularity,test,test_full                                             
         /home/runner/work/lsmquant/lsmquant/lsmquant/dev/main.nf' returned     
         non-zero error code '1':                                               
         >                                                                      
         Error workflows/lsmquant.nf:137:26: `img_dir` is already declared      
         │ 137 |             .map { meta, img_dir, parameter_file, stitched_data
         ->                                                                     
         ╰     |                          ^^^^^^^                               
                                                                                
                                                                                
         ERROR ~ Script compilation failed   

in : #61

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link
Copy Markdown
Contributor

@piplus2 piplus2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to use a consistent naming :)

Comment thread workflows/lsmquant.nf Outdated
Co-authored-by: Paolo Inglese <26252284+piplus2@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@piplus2 piplus2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done 🚀

@CaroAMN CaroAMN merged commit cae00d3 into nf-core:dev May 18, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants