Skip to content

Commit 43cabc5

Browse files
committed
style: trim verbose comments to only the non-obvious magic-number note
1 parent 5c1ec95 commit 43cabc5

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

bin/summarize_results.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ def process_file(file, prefix, quantify, keep_cols):
123123
quantify (bool): Retained for CLI back-compat only; format is auto-detected.
124124
keep_cols (list): Set of columns to keep from the original set of columns
125125
"""
126-
# Auto-detect format: multi-TSV (quant consensusXML) vs flat TSV (idXML / empty bypass)
127126
if is_multi_tsv(file):
128127
data = parse_multiTSV(file)
129128
n_psms = np.sum(data["psm"])

workflows/mhcquant.nf

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -165,19 +165,14 @@ workflow MHCQUANT {
165165
// SUBWORKFLOW: QUANT
166166
//
167167
if (params.quantify) {
168-
// Branch out samples with empty FDR-filtered idXMLs (zero peptides past FDR).
169-
// Re-uses the same countLines() > 130 heuristic as the SPECLIB path above.
170-
// Use `it[1]` (matches subworkflows/local/process_feature/main.nf:23) — destructuring
171-
// inside .branch can swallow the labels.
168+
// Empty FDR-filtered idXML (no peptides) is ~26 lines of OpenMS scaffolding.
172169
RESCORE.out.fdr_filtered
173170
.branch {
174171
non_empty: it[1].countLines() > 130
175172
empty: true
176173
}
177174
.set { ch_fdr_branched }
178175

179-
// Warn per empty sample; .subscribe matches the nf-core idiom used at
180-
// subworkflows/local/utils_nfcore_mhcquant_pipeline/main.nf:180
181176
ch_fdr_branched.empty.subscribe { item ->
182177
log.warn """\
183178
No peptides passed FDR filtering for sample '${item[0].id}'.
@@ -209,8 +204,6 @@ workflow MHCQUANT {
209204
PYOPENMS_IONANNOTATOR( ch_ion_annotator_input )
210205
}
211206

212-
// Export ID/quant result to TSV (handles both idXML and consensusXML inputs).
213-
// Per-sample emptiness warnings are emitted earlier (see QUANT branch above).
214207
OPENMS_TEXTEXPORTER(ch_output)
215208

216209
// Process the tsv file to facilitate visualization with MultiQC

0 commit comments

Comments
 (0)