Skip to content

Commit 3f44636

Browse files
authored
Fix Python/PyYAML case mismatch in toolReferencesMap (#238)
* Fix Python/PyYAML case mismatch in toolReferencesMap * Fix Python/PyYAML case mismatch: emit lowercase tool names in rundirparser module * snapshot * snapshot
1 parent c9f130c commit 3f44636

5 files changed

Lines changed: 22 additions & 21 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2828
- [#216](https://github.com/nf-core/seqinspector/pull/216) Fixed meta.id that resulted in all SEQFU_STATS processes with the same tag name
2929
- [#224](https://github.com/nf-core/seqinspector/pull/224) Fix workflow output syntax for future Nextflow releases
3030
- [#226](https://github.com/nf-core/seqinspector/pull/226) Fix parameter `tools_bundle` not accepting `null` for custom tool selection
31+
- [#238](https://github.com/nf-core/seqinspector/pull/238) Fix Python/PyYAML tool name case mismatch in rundirparser module
3132
- [#239](https://github.com/nf-core/seqinspector/pull/239) Fix tool bundles documentation to match code
3233
- [#240](https://github.com/nf-core/seqinspector/pull/240) Fix FASTQE default tool marking in README
3334

modules/local/rundirparser/main.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ process RUNDIRPARSER {
1313
output:
1414
tuple val(meta), val("${task.process}"), val('rundirparser'), path("*_mqc.yml"), emit: multiqc, topic: multiqc_files
1515
tuple val("${task.process}"), val('rundirparser'), val("1.0.1"), emit: versions_rundirparser, topic: versions
16-
tuple val("${task.process}"), val('Python'), eval("python --version |& sed '1!d ; s/Python //'"), emit: versions_python, topic: versions
17-
tuple val("${task.process}"), val('PyYAML'), eval("python -c 'import yaml; print(yaml.__version__)'"), emit: versions_pyyaml, topic: versions
16+
tuple val("${task.process}"), val('python'), eval("python --version |& sed '1!d ; s/Python //'"), emit: versions_python, topic: versions
17+
tuple val("${task.process}"), val('pyyaml'), eval("python -c 'import yaml; print(yaml.__version__)'"), emit: versions_pyyaml, topic: versions
1818

1919
when:
2020
task.ext.when == null || task.ext.when

modules/local/rundirparser/tests/main.nf.test.snap

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
[
1515
[
1616
"RUNDIRPARSER",
17-
"PyYAML",
18-
"6.0.2"
17+
"python",
18+
"3.13.2"
1919
],
2020
[
2121
"RUNDIRPARSER",
22-
"Python",
23-
"3.13.2"
22+
"pyyaml",
23+
"6.0.2"
2424
],
2525
[
2626
"RUNDIRPARSER",
@@ -29,7 +29,7 @@
2929
]
3030
]
3131
],
32-
"timestamp": "2026-06-15T13:07:57.646729989",
32+
"timestamp": "2026-06-16T16:34:39.967986788",
3333
"meta": {
3434
"nf-test": "0.9.5",
3535
"nextflow": "26.04.3"
@@ -50,13 +50,13 @@
5050
[
5151
[
5252
"RUNDIRPARSER",
53-
"PyYAML",
54-
"6.0.2"
53+
"python",
54+
"3.13.2"
5555
],
5656
[
5757
"RUNDIRPARSER",
58-
"Python",
59-
"3.13.2"
58+
"pyyaml",
59+
"6.0.2"
6060
],
6161
[
6262
"RUNDIRPARSER",
@@ -65,7 +65,7 @@
6565
]
6666
]
6767
],
68-
"timestamp": "2026-06-15T13:08:08.679341972",
68+
"timestamp": "2026-06-16T16:34:50.171365737",
6969
"meta": {
7070
"nf-test": "0.9.5",
7171
"nextflow": "26.04.3"

tests/NovaSeq6000.nf.test.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
"picard": "3.4.0"
2424
},
2525
"RUNDIRPARSER": {
26-
"PyYAML": "6.0.2",
27-
"Python": "3.13.2",
26+
"python": "3.13.2",
27+
"pyyaml": "6.0.2",
2828
"rundirparser": "1.0.1"
2929
},
3030
"SAMTOOLS_FAIDX": {
@@ -1498,7 +1498,7 @@
14981498
],
14991499
"No warnings"
15001500
],
1501-
"timestamp": "2026-06-15T13:14:55.481330865",
1501+
"timestamp": "2026-06-16T16:49:30.181322928",
15021502
"meta": {
15031503
"nf-test": "0.9.5",
15041504
"nextflow": "26.04.3"

tests/missing_rundir.nf.test.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
"fastqc": "0.12.1"
1111
},
1212
"RUNDIRPARSER": {
13-
"PyYAML": "6.0.2",
14-
"Python": "3.13.2",
13+
"python": "3.13.2",
14+
"pyyaml": "6.0.2",
1515
"rundirparser": "1.0.1"
1616
}
1717
},
@@ -80,7 +80,7 @@
8080
"WARN: nf-core pipelines do not accept positional arguments. The positional argument `true` has been detected."
8181
]
8282
],
83-
"timestamp": "2026-06-15T13:12:44.660216538",
83+
"timestamp": "2026-06-16T16:36:43.640701391",
8484
"meta": {
8585
"nf-test": "0.9.5",
8686
"nextflow": "26.04.3"
@@ -172,8 +172,8 @@
172172
"fastqc": "0.12.1"
173173
},
174174
"RUNDIRPARSER": {
175-
"PyYAML": "6.0.2",
176-
"Python": "3.13.2",
175+
"python": "3.13.2",
176+
"pyyaml": "6.0.2",
177177
"rundirparser": "1.0.1"
178178
}
179179
},
@@ -666,7 +666,7 @@
666666
"WARN: No rundir for sample(s): SampleA_02, sampletest_04"
667667
]
668668
],
669-
"timestamp": "2026-06-15T13:11:40.254224373",
669+
"timestamp": "2026-06-16T16:35:40.437220565",
670670
"meta": {
671671
"nf-test": "0.9.5",
672672
"nextflow": "26.04.3"

0 commit comments

Comments
 (0)