Skip to content

Commit c3df32e

Browse files
committed
Merge branch 'dev' into nf-core-template-merge-3.4.1
2 parents 4834318 + 4b8cd3d commit c3df32e

108 files changed

Lines changed: 6898 additions & 188 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/CONTRIBUTING.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,12 @@ If you wish to contribute a new step, please use the following coding standards:
8282
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
8383
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.
8484

85+
### Things to consider regarding displaying results for a new tool
86+
87+
- If a MultiQC module exist for the tool, use the standard settings for it to start with.
88+
- If no Multiqc module exists, the results of the tool should be made available in the results directory.
89+
- If a tool doesn’t produce output files, the stdout should be channeled into a output file that can be accessible from the outdir of the pipeline.
90+
8591
### Default values
8692

8793
Parameters should be initialised / defined with default values within the `params` scope in `nextflow.config`.

.github/workflows/awsfulltest.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ jobs:
2424
2525
- name: Launch workflow via Seqera Platform
2626
uses: seqeralabs/action-tower-launch@v2
27-
# TODO nf-core: You can customise AWS full pipeline tests as required
28-
# Add full size test data (but still relatively small datasets for few samples)
29-
# on the `test_full.config` test runs with only one set of parameters
3027
with:
3128
workspace_id: ${{ vars.TOWER_WORKSPACE_ID }}
3229
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,5 @@ testing/
77
testing*
88
*.pyc
99
null/
10+
.nf-test
11+
.nf-test.log

.nf-core.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
lint:
2-
files_exist:
3-
- .github/workflows/ci.yml
4-
files_unchanged:
5-
- .github/CONTRIBUTING.md
62
nextflow_config:
73
- config_defaults:
84
- params.fastq_screen_references

CHANGELOG.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,30 @@ Initial release of nf-core/seqinspector, created with the [nf-core](https://nf-c
99

1010
### `Added`
1111

12+
- [#114](https://github.com/nf-core/seqinspector/pull/114/) Update CI
13+
- [#75](https://github.com/nf-core/seqinspector/pull/75) Set up nft-utils
14+
- [#68](https://github.com/nf-core/seqinspector/pull/68) Add tool selector
15+
- [#20](https://github.com/nf-core/seqinspector/pull/20) Use tags to generate group reports
16+
- [#13](https://github.com/nf-core/seqinspector/pull/13) Generate reports per run, per project and per lane.
17+
- [#49](https://github.com/nf-core/seqinspector/pull/49) Merge with template 3.0.2.
18+
- [#56](https://github.com/nf-core/seqinspector/pull/56) Added SeqFu stats module.
19+
- [#50](https://github.com/nf-core/seqinspector/pull/50) Add an optional subsampling step.
20+
- [#51](https://github.com/nf-core/seqinspector/pull/51) Add nf-test to CI.
21+
- [#63](https://github.com/nf-core/seqinspector/pull/63) Contribution guidelines added about displaying results for new tools
22+
- [#53](https://github.com/nf-core/seqinspector/pull/53) Add FastQ-Screen database multiplexing and limit scope of nf-test in CI.
23+
- [#96](https://github.com/nf-core/seqinspector/pull/96) Added missing citations to citation tool
24+
- [#103](https://github.com/nf-core/seqinspector/pull/103) Configure full-tests
25+
- [#110](https://github.com/nf-core/seqinspector/pull/110) Update input schema to accept either tar file or directory as rundir, and fastq messages and patterns.
26+
1227
### `Fixed`
1328

29+
- [#71](https://github.com/nf-core/seqinspector/pull/71) FASTQSCREEN does not fail when multiple reads are provided.
30+
- [#99](https://github.com/nf-core/seqinspector/pull/99) Fix group reports for paired reads
31+
- [#107](https://github.com/nf-core/seqinspector/pull/107) Put SeqFU-stats section reports together
32+
- [#112](https://github.com/nf-core/seqinspector/pull/112) Making fastq_screen_references value to use parentDir
33+
1434
### `Dependencies`
1535

36+
- [#116](https://github.com/nf-core/seqinspector/pull/116) Update MultiQC to 1.28
37+
1638
### `Deprecated`

CITATIONS.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,20 @@
1414

1515
> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online].
1616
17+
- [SeqFu](https://telatin.github.io/seqfu2/)
18+
19+
> Telatin A, Fariselli P, Birolo G. SeqFu: A Suite of Utilities for the Robust and Reproducible Manipulation of Sequence Files. Bioengineering 2021, 8, 59. doi.org/10.3390/bioengineering8050059
20+
21+
- [FastQ Screen](https://www.bioinformatics.babraham.ac.uk/projects/fastq_screen/)
22+
23+
> Wingett SW and Andrews S. FastQ Screen: A tool for multi-genome mapping and quality control [version 2; referees: 4 approved]. F1000Research 2018, 7:1338 (https://doi.org/10.12688/f1000research.15931.2)
24+
1725
- [MultiQC](https://pubmed.ncbi.nlm.nih.gov/27312411/)
1826

1927
> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924.
2028
29+
- [Seqtk](https://github.com/lh3/seqtk)
30+
2131
## Software packaging/containerisation tools
2232

2333
- [Anaconda](https://anaconda.com)

README.md

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,34 +30,31 @@
3030
-->
3131

3232
<!-- TODO nf-core: Include a figure that guides the user through the major workflow steps. Many nf-core
33-
workflows use the "tube map" design for that. See https://nf-co.re/docs/guidelines/graphic_design/workflow_diagrams#examples for examples. -->
34-
<!-- TODO nf-core: Fill in short bullet-pointed list of the default steps in the pipeline -->1. Read QC ([`FastQC`](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/))2. Present QC for raw reads ([`MultiQC`](http://multiqc.info/))
33+
workflows use the "tube map" design for that. See https://nf-co.re/docs/contributing/design_guidelines#examples for examples. -->
34+
<!-- TODO nf-core: Fill in short bullet-pointed list of the default steps in the pipeline -->
35+
36+
1. Subsample reads ([`Seqtk`](https://github.com/lh3/seqtk))
37+
2. Read QC ([`FastQC`](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/))
38+
3. Present QC for raw reads ([`MultiQC`](http://multiqc.info/))
3539

3640
## Usage
3741

3842
> [!NOTE]
3943
> If you are new to Nextflow and nf-core, please refer to [this page](https://nf-co.re/docs/usage/installation) on how to set-up Nextflow. Make sure to [test your setup](https://nf-co.re/docs/usage/introduction#how-to-run-a-pipeline) with `-profile test` before running the workflow on actual data.
4044
41-
<!-- TODO nf-core: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
42-
Explain what rows and columns represent. For instance (please edit as appropriate):
43-
4445
First, prepare a samplesheet with your input data that looks as follows:
4546

4647
`samplesheet.csv`:
4748

4849
```csv
49-
sample,fastq_1,fastq_2
50-
CONTROL_REP1,AEG588A1_S1_L002_R1_001.fastq.gz,AEG588A1_S1_L002_R2_001.fastq.gz
50+
sample,fastq_1,fastq_2,rundir,tags
51+
CONTROL_REP1,AEG588A1_S1_L002_R1_001.fastq.gz,AEG588A1_S1_L002_R2_001.fastq.gz,200624_A00834_0183_BHMTFYDRXX,lane1:project5:group2
5152
```
5253

5354
Each row represents a fastq file (single-end) or a pair of fastq files (paired end).
5455

55-
-->
56-
5756
Now, you can run the pipeline using:
5857

59-
<!-- TODO nf-core: update the following command to include all required parameters for a minimal example -->
60-
6158
```bash
6259
nextflow run nf-core/seqinspector \
6360
-profile <docker/singularity/.../institute> \
@@ -78,11 +75,11 @@ For more details about the output files and reports, please refer to the
7875

7976
## Credits
8077

81-
nf-core/seqinspector was originally written by Adrien Coulier.
78+
nf-core/seqinspector was originally written by the Swedish [@NationalGenomicsInfrastructure](https://github.com/NationalGenomicsInfrastructure/).
8279

8380
We thank the following people for their extensive assistance in the development of this pipeline:
8481

85-
<!-- TODO nf-core: If applicable, make list of people who have also contributed -->
82+
- [@mahesh-panchal](https://github.com/mahesh-panchal)
8683

8784
## Contributions and Support
8885

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
name,dir,basename,aligner
2+
Ecoli,s3://ngi-igenomes/igenomes/Escherichia_coli_K_12_MG1655/NCBI/2001-10-15/Sequence/Bowtie2Index/,genome,bowtie2
3+
PhiX,s3://ngi-igenomes/igenomes/PhiX/Illumina/RTA/Sequence/Bowtie2Index/,genome,bowtie2
4+
Scerevisiae,s3://ngi-igenomes/igenomes/Saccharomyces_cerevisiae/NCBI/build3.1/Sequence/Bowtie2Index/,genome,bowtie2

assets/samplesheet.csv

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1-
sample,fastq_1,fastq_2
2-
SAMPLE_PAIRED_END,/path/to/fastq/files/AEG588A1_S1_L002_R1_001.fastq.gz,/path/to/fastq/files/AEG588A1_S1_L002_R2_001.fastq.gz
3-
SAMPLE_SINGLE_END,/path/to/fastq/files/AEG588A4_S4_L003_R1_001.fastq.gz,
1+
sample,fastq_1,fastq_2,rundir,tags
2+
SAMPLE_PAIRED_END,/path/to/fastq/files/AEG588A1_S1_L002_R1_001.fastq.gz,/path/to/fastq/files/AEG588A1_S1_L002_R2_001.fastq.gz,/path/to/rundir,paired_sample:lane1
3+
SAMPLE_PAIRED_END,/path/to/fastq/files/AEG588A2_S2_L002_R1_001.fastq.gz,/path/to/fastq/files/AEG588A2_S2_L002_R2_001.fastq.gz,/path/to/rundir,paired_sample:lane1
4+
SAMPLE_PAIRED_END,/path/to/fastq/files/AEG588A3_S3_L002_R1_001.fastq.gz,/path/to/fastq/files/AEG588A3_S3_L002_R2_001.fastq.gz,/path/to/rundir,paired_sample:lane2
5+
SAMPLE_SINGLE_END,/path/to/fastq/files/AEG588A4_S4_L003_R1_001.fastq.gz,,/path/to/rundir,group1
6+
SAMPLE_SINGLE_END,/path/to/fastq/files/AEG588A4_S4_L003_R1_001.fastq.gz,,/path/to/rundir,group2
7+
SAMPLE_SINGLE_END,/path/to/fastq/files/AEG588A4_S4_L003_R1_001.fastq.gz,,/path/to/rundir,group3
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
{
2+
"$schema": "https://json-schema.org/draft/2020-12/schema",
3+
"$id": "https://raw.githubusercontent.com/nf-core/seqinspector/master/assets/schema_fastq_screen_references.json",
4+
"title": "nf-core/seqinspector pipeline - params.fastq_screen_references schema",
5+
"description": "Schema for the file provided with params.fastq_screen_references",
6+
"type": "array",
7+
"items": {
8+
"type": "object",
9+
"properties": {
10+
"name": {
11+
"type": "string",
12+
"pattern": "^\\S+$",
13+
"errorMessage": "The reference name as referred to by FastQ Screen."
14+
},
15+
"dir": {
16+
"type": "string",
17+
"format": "directory-path",
18+
"exists": true,
19+
"pattern": "^\\S+$",
20+
"errorMessage": "Path to the dir containing the aligner reference and index. Can be remote."
21+
},
22+
"basename": {
23+
"type": "string",
24+
"pattern": "^\\S+$",
25+
"errorMessage": "The shared basename of the reference and index files contained in the dir."
26+
},
27+
"aligner": {
28+
"type": "string",
29+
"enum": ["bowtie", "bowtie2", "bwa", "minimap2"],
30+
"errorMessage": "Specify the aligner to use for the mapping. Valid arguments are 'bowtie', bowtie2' (default), 'bwa' or 'minimap2'."
31+
}
32+
},
33+
"required": ["name", "dir", "basename", "aligner"]
34+
}
35+
}

0 commit comments

Comments
 (0)