Use UTC timestamps everywhere

[grst]

Addressing Claude's (IMO valid) concern that UTC timestamps should be used instead of local ones.

[netlify]

✅ Deploy Preview for nf-core-stats ready!

Name	Link
🔨 Latest commit	5f42301
🔍 Latest deploy log	https://app.netlify.com/projects/nf-core-stats/deploys/69022d197faa310008fc762f
😎 Deploy Preview	https://deploy-preview-94--nf-core-stats.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[claude]

Claude finished @grst's task —— View job

---

Code Review: Use UTC timestamps everywhere

I've reviewed the UTC timestamp changes across all 4 files. This is a well-executed improvement that addresses timezone consistency issues.

Todo List:

• Read and analyze the 4 modified files
• Review timestamp handling changes for correctness
• Check for potential bugs and security concerns
• Evaluate performance implications
• Assess test coverage needs
• Provide comprehensive review feedback

✅ Overall Assessment

This PR successfully addresses timezone consistency by converting all datetime.now() and datetime.fromtimestamp() calls to use UTC timezone explicitly. The changes are systematic, correct, and improve data reliability.

📋 Detailed Review

Code Quality & Correctness

• Excellent: All timestamp operations now properly specify timezone.utc
• Consistent imports: Added timezone import to all modified files
• Proper timezone handling: Used .replace(tzinfo=timezone.utc) for parsed datetime strings and tz=timezone.utc for timestamp conversions

Key Changes Reviewed

1. _github.py (lines 46, 79, 89-91):

   • ✅ Rate limit reset times now correctly use UTC
   • ✅ Proper error handling maintains timezone awareness

2. citations_pipeline.py (line 85):

   • ✅ Citation collection timestamps now UTC-based
   • ℹ️ Also added proper exception raising on line 18 (good defensive coding)

3. github_pipeline.py (lines 70, 74-75, 179, 232, 236, 267-269, 310, 409):

   • ✅ Traffic stats filtering now uses UTC for date comparisons
   • ✅ Contributor stats week calculations properly timezone-aware
   • ✅ Issue timestamps and duration calculations now consistent
   • ✅ Organization member collection uses UTC timestamps
   • ✅ Commit stats processing properly handles timezones

4. slack_pipeline.py (line 174):

   • ✅ Slack stats collection now generates UTC timestamps

Potential Issues & Recommendations

• None identified: All changes are implemented correctly
• Database impact: Existing data with local timestamps will need consideration during migration
• Documentation: Consider updating any documentation that references timestamp formats

Performance Implications

• Minimal impact: Timezone operations add negligible overhead
• Improved reliability: UTC timestamps prevent daylight saving time issues
• Better data consistency: All timestamps now follow same standard

Security & Best Practices

• No security concerns: Changes are purely timestamp formatting
• Follows best practices: UTC is the standard for data storage and logging
• Maintains backward compatibility: String formats remain consistent

Test Coverage

The changes are straightforward timezone improvements, but consider:

• Testing with data spanning timezone transitions
• Verifying date filtering logic works correctly with UTC timestamps
• Ensuring incremental loading continues to work properly

🎯 Summary

This is a high-quality improvement that:

• ✅ Fixes timezone inconsistency issues
• ✅ Implements changes systematically across all pipeline files
• ✅ Uses proper datetime best practices
• ✅ Maintains existing functionality while improving reliability

Recommendation: Approve - This PR successfully addresses the UTC timestamp concerns and improves the codebase reliability.

---