Skip to content

Add new datasets for the new pipeline structure#2105

Merged
LuisHeinzlmeier merged 3 commits into
nf-core:scspatialmapfrom
askmadsen:scspatialmap
Jun 17, 2026
Merged

Add new datasets for the new pipeline structure#2105
LuisHeinzlmeier merged 3 commits into
nf-core:scspatialmapfrom
askmadsen:scspatialmap

Conversation

@askmadsen

Copy link
Copy Markdown

This PR adds updated minimal test datasets for the scspatialmap pipeline to align with the new pipeline structure.

@piplus2 piplus2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piplus2 piplus2 self-requested a review June 17, 2026 09:54

@piplus2 piplus2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this deletion affect samplesheet_spot.csv ?

EDIT: ok I see, they are different. Good then.

@piplus2 piplus2 self-requested a review June 17, 2026 09:55

@piplus2 piplus2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the urls

sample,single_cell,spatial,ground_truth
test1,https://github.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_sc.h5ad,https://github.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_sp.h5ad,https://github.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_gt.csv
sample,single_cell,spatial
test1,https://raw.githubusercontent.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_sc.h5ad,https://raw.githubusercontent.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_sp.h5ad

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test1,https://raw.githubusercontent.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_sc.h5ad,https://raw.githubusercontent.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_sp.h5ad
test1,https://raw.githubusercontent.com/nf-core/test-datasets/scspatialmap/datasets/sc/min_sc.h5ad,https://raw.githubusercontent.com/nf-core/test-datasets/scspatialmap/datasets/sc/min_sp.h5ad

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the URL paths

Comment thread samplesheets/samplesheet_sc_spatial.csv Outdated
@@ -0,0 +1,2 @@
sample,spatial
test1,https://raw.githubusercontent.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_spatial.h5ad

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test1,https://raw.githubusercontent.com/nf-core/test-datasets/raw/refs/heads/scspatialmap/datasets/sc/min_spatial.h5ad
test1,https://raw.githubusercontent.com/nf-core/test-datasets/scspatialmap/datasets/sc/min_spatial.h5ad

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the URL paths

@askmadsen askmadsen requested a review from piplus2 June 17, 2026 10:27

@piplus2 piplus2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@askmadsen

Copy link
Copy Markdown
Author

Thank you very much for your help

@LuisHeinzlmeier LuisHeinzlmeier merged commit 81a99bb into nf-core:scspatialmap Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants