Commit b4376ac
Add or update terms based on GitHub issue suggestions (#779)
* Add or update terms based on GitHub issue suggestions
Completed with AI assistance from Claude Code
✅ Issue #757 - Sphere Formation Assay
- Added "sphere formation" as a new term in modules/Assay/Assay.yaml:827-834
- Added "tumor spheroid formation assay" as an alias
- Linked with cross-references to related terms ("in vitro tumorigenesis" and "Matrigel-based tumorigenesis assay")
- Updated "Matrigel-based tumorigenesis assay" description to reference "sphere formation"
✅ Issue #662 - Weight Assay
- Added "weight" with EFO:0004338 in modules/Assay/Assay.yaml:546-548
- Placed in ClinicalBehavioralAssayEnum section
⏭️ Issue #646 - Cancer Diagnosis
- Skipped - Determined "cancer" is too broad/vague for this specialized NF metadata dictionary
- Existing specific cancer/tumor types are more appropriate
✅ Issue #185 - Mouse Models
- Added "Nf1-MET" to modules/Sample/AnimalModelManual.yaml:20-21
- Added "Nf1-P53" to modules/Sample/AnimalModelManual.yaml:26-27
- Both follow existing naming conventions
All changes maintain alphabetical ordering and follow the existing file structure conventions.
* Update Assay.yaml
Remove similar assays from see_also to resolve error 'sphere formation is not a valid URI or CURIE' since 'see_also field should only contain URLs/URIs, not references to other terms in the schema'
Completed with AI assistance from Claude Code
* Consolidate tumorigenesis assay terms
Completed with AI assistance from Claude Code
* Remove mRNA counts assay term and move NanoString nCounter from assay to platform
Completed with AI assistance from Claude Code
Fixes #704 - mRNA Counts Confusion
- Removed "mRNA counts" from Assay.yaml (was data output, not an assay type)
- Removed "NanoString nCounter Analysis System" from Assay.yaml (was misplaced - it's a platform, not an assay)
- Added "NanoString nCounter Analysis System" to modules/Assay/Platform.yaml:133-139 in ArrayPlatformEnum
- Aliases for backwards compatibility: NanoString, NanoString nCounter, Nanostring Counter
* Add titles
Add titles to hopefully make terms more user-friendly to fix #770
* Move title after notes for 'Germline Mutation'
* Add key for number of PCR cycles for library
Fixes #631 . Completed with AI assistance from Claude Code
* Change 'meaning' to 'slot_uri' to resolve bug
---------
Co-authored-by: Anh Nguyet Vu <32753274+anngvu@users.noreply.github.com>1 parent 6f2230a commit b4376ac
File tree
4 files changed
+204
-16
lines changed- modules
- Assay
- Sample
4 files changed
+204
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
546 | 549 | | |
547 | 550 | | |
548 | 551 | | |
| |||
587 | 590 | | |
588 | 591 | | |
589 | 592 | | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | 593 | | |
595 | 594 | | |
596 | 595 | | |
597 | | - | |
598 | | - | |
599 | | - | |
600 | | - | |
601 | | - | |
602 | | - | |
603 | 596 | | |
604 | 597 | | |
605 | 598 | | |
| |||
729 | 722 | | |
730 | 723 | | |
731 | 724 | | |
732 | | - | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
733 | 731 | | |
734 | 732 | | |
735 | 733 | | |
| |||
751 | 749 | | |
752 | 750 | | |
753 | 751 | | |
754 | | - | |
755 | | - | |
756 | 752 | | |
757 | 753 | | |
758 | 754 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
134 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
135 | 140 | | |
136 | 141 | | |
137 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| 26 | + | |
| 27 | + | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
| |||
0 commit comments