Revert "ads"

Author: mvoelken-hub

scripts/inbox_to_schema.py

@@ -531,35 +531,25 @@ def plan_changes(
                             effective_class, slot_origin, class_origin,
                             changes, reporter,
                         )
-                    elif derived_name in get_all_class_slots(schema, effective_class):
-                        # Slot already belongs to the subclass hierarchy (its own
-                        # slots: list or a mixin) and cannot be modified via the
-                        # inbox workflow.  Skip silently — these rows are
-                        # structural display information from the Excel
+                    else:
+                        # Slot belongs to the subclass hierarchy (mixin,
+                        # attribute, or imported slot) and cannot be modified
+                        # via the inbox workflow.  Skip silently — these rows
+                        # are structural display information from the Excel
                         # generator, not editable fields.
                         reporter.info(
                             sheet_title, f"slot '{label}'",
                             f"Skipped: belongs to sub-class `{effective_class}` "
                             f"and is not modifiable via the inbox workflow "
                             f"(edit the YAML directly).",
                         )
-                    else:
-                        # Unknown slot assigned to a domain class that does not
-                        # already define it → a genuinely new slot to be added to
-                        # that subclass (e.g. anode/cathode on ElectrochemicalReactor).
-                        # _plan_new_slot resolves the owner class from the domain.
-                        _plan_new_slot(
-                            row, sheet_title, schema_class,
-                            schema, class_origin, slot_origin, label_to_slot,
-                            label_to_class, changes, reporter,
-                        )
 
                 else:
                     # ── Unknown label + empty domain → new top-level slot ──
                     _plan_new_slot(
                         row, sheet_title, schema_class,
                         schema, class_origin, slot_origin, label_to_slot,
-                        label_to_class, changes, reporter,
+                        changes, reporter,
                     )
 
             elif row_type == "class":
@@ -788,31 +778,23 @@ def _plan_new_slot(
     class_origin: dict[str, Path],
     slot_origin: dict[str, Path],
     label_to_slot: dict[str, str],
-    label_to_class: dict[str, str],
     changes: list,
     reporter: Reporter,
 ) -> None:
     label     = row["label"]
     domain    = row["domain"]
     slot_name = _label_to_slot_name(label)
 
-    # Resolve the class that will own the new slot:
-    #   • empty domain     → the sheet's top-level data class (schema_class)
-    #   • non-empty domain → the named subclass (e.g. ElectrochemicalReactor),
-    #                        added to that class exactly like the top-level case.
+    # Only top-level new slots are supported (domain must be empty)
     if domain:
-        owner_class = label_to_class.get(domain) or domain
-        if owner_class not in schema.get("classes", {}):
-            reporter.error(
-                sheet, f"new slot '{label}'",
-                f"The domain `{domain}` is not a recognised class. "
-                f"Set the domain column to an existing class label, or leave it "
-                f"empty to add a top-level slot.",
-                hint="Look at the class rows in this sheet for valid domain names.",
-            )
-            return
-    else:
-        owner_class = schema_class
+        reporter.error(
+            sheet, f"new slot '{label}'",
+            f"New slots may only be added at the top level of a data class "
+            f"(the **domain** column must be empty). Got domain=`{domain}`.",
+            hint="To add a slot inside a subclass, edit the YAML directly. "
+                 "For a top-level slot, leave the domain column empty.",
+        )
+        return
 
     # Name conflict: same derived name as an existing slot
     if slot_name in schema.get("slots", {}):
@@ -845,16 +827,16 @@ def _plan_new_slot(
         )
         return
 
-    target = class_origin.get(owner_class, SCHEMA_DIR / MODULE_FILES[-1])
+    target = class_origin.get(schema_class, SCHEMA_DIR / MODULE_FILES[-1])
     reporter.info(
         sheet, f"new slot `{slot_name}`",
-        f"Will add `{slot_name}` to `{owner_class}`.",
+        f"Will add `{slot_name}` to `{schema_class}`.",
     )
     changes.append({
         "type":           "slot_add",
         "name":           slot_name,
         "label":          label,
-        "schema_class":   owner_class,
+        "schema_class":   schema_class,
         "range":          range_val,
         "mro":            mro,
         "description":    row["description"],

src/coremeta4cat/schema/coremeta4cat_reaction_ap.yaml

@@ -166,9 +166,6 @@ classes:
       Electrochemical reactor used in electrocatalytic experiments, including
       H-cells, flow cells, and membrane electrode assemblies.
 
-    slots:
-    - anode
-    - cathode
   CSTR:
     is_a: ChemicalReactor
     class_uri: VOC4CAT:0007019
@@ -319,11 +316,3 @@ slots:
     required: true
     multivalued: true
     inlined_as_list: true
-  anode:
-    description: The electrode where oxidation occurs in an electrochemical cell. It is the positive electrode in an electrolytic cell, while it is the negative electrode in a galvanic cell.
-    slot_uri: VOC4CAT:0007254
-    required: true
-  cathode:
-    description: The electrode where reduction occurs in an electrochemical cell. It is the negative electrode in an electrolytic cell, while it is the positive electrode in a galvanic cell.
-    slot_uri: VOC4CAT:0007255
-    required: true