This repository contains a SKOS vocabulary for catalysis. When reviewing pull requests, please help contributors follow these best practices:
Problem: New concepts in the SKOS vocabulary must be properly classified by linking them to the hierarchy through skos:broader relationships, eventually reaching one of the top concepts.
What to look for:
- Excel files in
inbox-excel-vocabs/with new concepts - Check if new concepts have
skos:broaderrelationships defined - Verify the broader concepts eventually chain to a top concept like:
- Process
- Method
- Material entity
- Quality
- Role
- etc.
Suggested response:
I noticed some new concepts in your submission. Please ensure each new concept has:
1. A `skos:broader` relationship to a parent concept
2. A chain of broader relationships that eventually reaches one of the top-level concepts
This ensures proper integration into the vocabulary hierarchy. You can check the existing vocabulary structure at https://nfdi4cat.github.io/voc4cat/ for examples.
Let me know if you need help identifying the appropriate parent concepts!
- Small, focused changes: Single concept additions or small groups (~20 concepts)
- Clear descriptions: Explain what the concepts represent and why they're needed
- Proper classification: All concepts linked into the hierarchy
- Use Excel workflow: Never edit .ttl files directly, only the Excel template
- Request ID ranges: Get an ID range before adding new concepts
- File locations: Excel files must be in
inbox-excel-vocabs/ - File naming: Keep as
voc4cat.xlsx - No direct .ttl edits: Turtle files should only be modified by CI
- Documentation: Changes should be described in PR description
- Size: Large contributions should be split into smaller PRs
- Contributing Guide: https://github.com/nfdi4cat/voc4cat/blob/main/docs/docs_usage/how-to-contribute.md
- Vocabulary Guidelines: https://github.com/nfdi4cat/voc4cat/blob/main/docs/docs_usage/guidelines.md
- Current Vocabulary as HTML: https://nfdi4cat.github.io/voc4cat/dev/voc4cat/index.html
- Current Vocabulary in SKOS/turtle format: https://github.com/nfdi4cat/voc4cat/tree/main/vocabularies/voc4cat
- Be welcoming and encouraging, especially to first-time contributors
- Explain why something is important, not just that it's required
- Provide concrete, actionable steps to fix issues
- Acknowledge that GitHub's limitations (like org forks) aren't the contributor's fault
- Offer to help if contributors have questions
- Don't block PRs unnecessarily - some issues can be fixed post-merge
- Don't be overly verbose - keep feedback concise and actionable
- Don't criticize the contributor - focus on the code/process
- Don't request changes for minor style issues in definitions
- Don't duplicate feedback if it's already been mentioned
- Critical: Organization account issues (blocks CI)
- Important: Missing classification (affects vocabulary quality)
- Helpful: Main branch usage (improves contributor workflow)
- Nice-to-have: Documentation improvements, minor formatting
Focus feedback on critical and important issues first. Mention helpful suggestions but don't insist on them for small contributions.