Skip to content

Commit 9b30925

Browse files
committed
Improve copilot-instructions
- don't duplicate PR summary - review concept organization/hierarchy
1 parent 9d4bc56 commit 9b30925

1 file changed

Lines changed: 16 additions & 3 deletions

File tree

.github/copilot-instructions.md

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ Let me know if you need help identifying the appropriate parent concepts!
3737

3838
### PR Review Style (Concise, no diff rehash)
3939

40-
- Summarize changes in plain language: what changed and why.
40+
- Do summarize changes in plain language: what changed and why.
41+
- Do not summarise changes if the starting message of the PR already contains a summary.
4142
- Do not restate or quote diffs, hunks, or line-by-line changes.
4243
- Do not link to individual file diffs; reference files only when necessary (path + short purpose).
4344
- Focus feedback on correctness, classification, scope, and follow-ups rather than code excerpts.
@@ -74,6 +75,18 @@ Use simple heuristics based on PR intent and CI signals:
7475
2. **No direct .ttl edits**: Turtle files should only be modified by CI
7576
3. **Documentation**: Changes should be described in PR description
7677
4. **Size**: Large contributions should be split into smaller PRs
78+
5. **Organizational guidelines conformance**: Check adherence to Voc4Cat guidelines (labels, British English, definitions, duplicate avoidance) and concept organization rules (IS-A only in hierarchy, attributes not placed under entities, generic attribute concepts preferred, collections used for HAS-A/context, no PART-OF modeling in `skos:broader`).
79+
80+
### Organizational Guidelines Conformance (Detail)
81+
82+
When reviewing, explicitly verify the PR aligns with internal vocabulary organization policies:
83+
84+
- **Hierarchy purity**: `skos:broader` / `skos:narrower` express only IS-A; no PART-OF or HAS-A misuse (see `docs/docs_usage/organizing-concepts.md`).
85+
- **Attribute purity**: Avoid object-specific attribute proliferation (preferred generic attributes).
86+
- **Collections usage**: Contextual HAS-A groupings use `skos:Collection` rather than hierarchical placement.
87+
- **Guidelines adherence**: Preferred label form, British English spelling, noun/noun-phrase, singular/plural rules, avoidance of trademarked names, non-circular concise definitions (see `docs/docs_usage/guidelines.md`).
88+
89+
If any of these are violated, add a short actionable note (e.g., "Hierarchy misuse – attribute concept placed under entity; move under appropriate attribute parent"). Keep blocking vs. follow-up issues distinct.
7790

7891
### Helpful Resources
7992

@@ -126,9 +139,9 @@ Classification:
126139
Quality:
127140
- PrefLabel + definition present (EN) per concept
128141
- No direct .ttl edits; TTL generated by CI
129-
- Conformance to guidelines <https://github.com/nfdi4cat/voc4cat/blob/main/docs/docs_usage/guidelines.md>:
142+
- Conformance to guidelines <https://github.com/nfdi4cat/voc4cat/blob/main/docs/docs_usage/guidelines.md> and concept organization <https://github.com/nfdi4cat/voc4cat/blob/main/docs/docs_usage/organizing-concepts.md>:
130143
British English; noun/noun-phrase form; duplicates avoided; appropriate
131-
hyphenation; no slashes; definitions concise and non-circular.
144+
hyphenation; no slashes; definitions concise and non-circular; IS-A-only hierarchy; attributes not under entities; collections for contextual HAS-A.
132145
133146
Suggestions (optional):
134147
- <brief, actionable improvements; keep it short>

0 commit comments

Comments
 (0)