SEM terms - #205
Merged
Merged
Conversation
Fixed the missing definition
…into SEM-Terms
Collaborator
|
@HendrikBorgelt: Thanks for your contribution! From my side the concepts and their definitions look good. But I wouldn't put the concepts under "SEM measurement attribute" as I guess that the concepts are not SEM-specific. Maybe @dalito can also comment on that. |
dalito
requested changes
Nov 16, 2025
dalito
left a comment
dalito
left a comment
Member
There was a problem hiding this comment.
See comments. The main suggestion is to make 7130 a collection instead of a concept.
Added the missing closing bracket ")" in voc4cat/0007131.ttl and changed voc4cat/0007130.ttl from beeing a concept into beeing a collection.
dalito
approved these changes
Nov 18, 2025
github-project-automation
Bot
moved this from In progress
to Completed
in Voc4Cat cross-repo view
HendrikBorgelt
added a commit
to HendrikBorgelt/voc4cat
that referenced
this pull request
Feb 13, 2026
Added terms relevant for SEM Measurements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added terms for Scanning Electron Microscopy (SEM) Measurements, which are important to describe e.g. the surface of a catalyst, as well as a collection for relevant measurement metadata.
I also added a class/term for "SEM measurement attribute" to reduce the number of child classes of the main "attribute" class. I don't know whether this is acceptable, if not, I can switch back to making everything into a child of attribute.