Merge pull request #503 from nflverse/catch-na-spreads

Catch missing `spread_line` data

Author: mrcaseb

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: nflfastR
 Title: Functions to Efficiently Access NFL Play by Play Data
-Version: 5.0.0.9000
+Version: 5.0.0.9001
 Authors@R: 
     c(person(given = "Sebastian",
              family = "Carl",

NEWS.md

@@ -1,6 +1,7 @@
 # nflfastR (development version)
 
 - Fixed a bug where `calculate_stats()` incorrectly counted `receiving_air_yards`. (#500)
+- Fixed a bug where `vegas_wp` variables were broken when `spread_line` data was missing. (#503)
 
 # nflfastR 5.0.0
 

R/helper_add_ep_wp.R

@@ -196,6 +196,24 @@ wp_spread_model_select <- function(pbp) {
 }
 prepare_wp_data <- function(pbp) {
 
+  if (any(is.na(pbp$spread_line))){
+    broken_games <- pbp %>%
+      dplyr::filter(is.na(.data$spread_line)) %>%
+      dplyr::pull(game_id) %>%
+      unique() %>%
+      sort()
+    cli::cli_alert_danger(
+      "The following game{?s} {?is/are} missing valid spread lines: {.val {broken_games}}."
+    )
+    cli::cli_alert_warning(
+      "nflfastR will manually set the spread for the home team to {.val 1.5} points!"
+    )
+    cli::cli_alert_warning(
+      "If you see this, please reach out to the package maintainers {.url https://github.com/nflverse/nflfastR/issues}"
+    )
+    pbp$spread_line[is.na(pbp$spread_line)] <- 1.5
+  }
+
   pbp <- pbp %>%
     dplyr::group_by(.data$game_id) %>%
     dplyr::mutate(

nflfastR.Rproj

@@ -1,4 +1,5 @@
 Version: 1.0
+ProjectId: e1e14382-386c-49b3-9b3f-206a4cc98503
 
 RestoreWorkspace: Default
 SaveWorkspace: Default