prevent users from choosing archived forms

Author: danielbarela

CHANGELOG.md

@@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.
 Adheres to [Semantic Versioning](http://semver.org/).
 
 ---
+## 3.0.3
+
+##### Bug Fixes
+* archived forms are no longer shown in the form picker
+
 ## 3.0.2
 
 ##### Bug Fixes

MAGE.xcodeproj/project.pbxproj

@@ -3578,7 +3578,7 @@
 				GCC_PREFIX_HEADER = "Mage/MAGE-Prefix.pch";
 				INFOPLIST_FILE = "Mage/MAGE-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 13.4;
-				MARKETING_VERSION = 3.0.2;
+				MARKETING_VERSION = 3.0.3;
 				OTHER_LDFLAGS = "$(inherited)";
 				PRODUCT_BUNDLE_IDENTIFIER = mil.nga.mage;
 				PRODUCT_NAME = MAGE;
@@ -3612,7 +3612,7 @@
 				GCC_PREFIX_HEADER = "Mage/MAGE-Prefix.pch";
 				INFOPLIST_FILE = "Mage/MAGE-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 13.4;
-				MARKETING_VERSION = 3.0.2;
+				MARKETING_VERSION = 3.0.3;
 				OTHER_LDFLAGS = "$(inherited)";
 				PRODUCT_BUNDLE_IDENTIFIER = mil.nga.mage;
 				PRODUCT_NAME = MAGE;

Mage/ObservationEditCoordinator.swift

@@ -249,7 +249,9 @@ extension ObservationEditCoordinator: ObservationEditCardDelegate {
     }
 
     func addForm() {
-        let forms: [[String: AnyHashable]] = event.forms as! [[String : AnyHashable]];
+        let forms: [[String: AnyHashable]] = (event.forms as! [[String : AnyHashable]]).filter { form in
+            return !(form[FormKey.archived.rawValue] as? Bool ?? false)
+        };
         let formPicker: FormPickerViewController = FormPickerViewController(delegate: self, forms: forms, observation: observation, scheme: self.scheme);
         formPicker.applyTheme(withScheme: scheme);
         bottomSheet = MDCBottomSheetController(contentViewController: formPicker);