Revert "fix more action stuff"

This reverts commit 5b13a32.

Author: ryanslatten

.github/workflows/build_test.service.yaml

@@ -64,7 +64,7 @@ jobs:
           cd service
           npm ci service
       - name: download service package
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: mage.service-artifacts
       - name: extract service lib

.github/workflows/release.arcgis_plugin.yaml

@@ -17,11 +17,12 @@ on:
   # release:
 
 jobs:
+
   config:
     uses: ./.github/workflows/config.yaml
 
   check_release_version:
-    needs: [config]
+    needs: [ config ]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -40,16 +41,16 @@ jobs:
           [[ $(json version < ./plugins/arcgis/web-app/package.json) = ${{ inputs.version }} ]] || exit 1
 
   build_and_test-service:
-    needs: [check_release_version]
+    needs: [ check_release_version ]
     uses: ./.github/workflows/build_test.arcgis.service.yaml
 
   build_and_test-web-app:
-    needs: [check_release_version]
+    needs: [ check_release_version ]
     uses: ./.github/workflows/build_test.arcgis.web-app.yaml
 
   publish_packages:
-    name: publish packages
-    needs: [config, build_and_test-service]
+    name:  publish packages
+    needs: [ config, build_and_test-service ]
     runs-on: ubuntu-latest
     steps:
       - name: setup node
@@ -59,11 +60,11 @@ jobs:
       - name: install json util
         run: npm i -g json
       - name: download service packages
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: arcgis.service-artifacts
       - name: download web-app packages
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: arcgis.web-app-artifacts
       - name: publish to package registry

.github/workflows/release.image_plugin.yaml

@@ -17,11 +17,12 @@ on:
   # release:
 
 jobs:
+
   config:
     uses: ./.github/workflows/config.yaml
 
   check_release_version:
-    needs: [config]
+    needs: [ config ]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -40,16 +41,16 @@ jobs:
       #     [[ $(json version < ./web-app/package.json) = ${{ inputs.version }} ]] || exit 1
 
   build_and_test-service:
-    needs: [check_release_version]
+    needs: [ check_release_version ]
     uses: ./.github/workflows/build_test.image.service.yaml
 
   # build_and_test-web-app:
   #   needs: [ check_release_version ]
   #   uses: ./.github/workflows/build_test.image.web-app.yaml
 
   publish_packages:
-    name: publish packages
-    needs: [config, build_and_test-service]
+    name:  publish packages
+    needs: [ config, build_and_test-service ]
     runs-on: ubuntu-latest
     steps:
       - name: setup node
@@ -59,7 +60,7 @@ jobs:
       - name: install json util
         run: npm i -g json
       - name: download service packages
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: image.service-artifacts
       - name: publish to package registry

.github/workflows/release.nga-msi_plugin.yaml

@@ -17,11 +17,12 @@ on:
   # release:
 
 jobs:
+
   config:
     uses: ./.github/workflows/config.yaml
 
   check_release_version:
-    needs: [config]
+    needs: [ config ]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -37,12 +38,12 @@ jobs:
           [[ $(json version < ./plugins/nga-msi/package.json) = ${{ inputs.version }} ]] || exit 1
 
   build_and_test-service:
-    needs: [check_release_version]
+    needs: [ check_release_version ]
     uses: ./.github/workflows/build_test.nga-msi.yaml
 
   publish_packages:
-    name: publish packages
-    needs: [config, build_and_test-service]
+    name:  publish packages
+    needs: [ config, build_and_test-service ]
     runs-on: ubuntu-latest
     steps:
       - name: setup node
@@ -52,7 +53,7 @@ jobs:
       - name: install json util
         run: npm i -g json
       - name: download service packages
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: nga-msi-artifacts
       - name: publish to package registry

.github/workflows/release.yaml

@@ -27,11 +27,12 @@ on:
   # release:
 
 jobs:
+
   config:
     uses: ./.github/workflows/config.yaml
 
   check_release_version:
-    needs: [config]
+    needs: [ config ]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -56,16 +57,16 @@ jobs:
           [[ $(json version < ./web-app/projects/core-lib/package.json) = ${{ inputs.version }} ]] || exit 1
 
   build_and_test-service:
-    needs: [check_release_version]
+    needs: [ check_release_version ]
     uses: ./.github/workflows/build_test.service.yaml
 
   build_and_test-web-app:
-    needs: [check_release_version]
+    needs: [ check_release_version ]
     uses: ./.github/workflows/build_test.web-app.yaml
 
   create_release:
     name: create release
-    needs: [config, build_and_test-service, build_and_test-web-app]
+    needs: [ config, build_and_test-service, build_and_test-web-app ]
     runs-on: ubuntu-latest
     steps:
       - name: setup node
@@ -75,11 +76,11 @@ jobs:
       - name: install json util
         run: npm i -g json
       - name: download service artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: mage.service-artifacts
       - name: download web-app artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: mage.web-app-artifacts
       - name: generate instance package.json
@@ -107,8 +108,8 @@ jobs:
             ngageoint-mage.*.tgz
 
   publish_packages:
-    name: publish packages
-    needs: [config, create_release]
+    name:  publish packages
+    needs: [ config, create_release ]
     runs-on: ubuntu-latest
     steps:
       - name: setup node
@@ -118,11 +119,11 @@ jobs:
       - name: install json util
         run: npm i -g json
       - name: download service packages
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: mage.service-artifacts
       - name: download web-app packages
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
           name: mage.web-app-artifacts
       - name: publish to package registry

plugins/arcgis/service/package.json

@@ -47,9 +47,6 @@
     "@ngageoint/mage.service": "^6.2.9 || ^6.3.0-beta",
     "express": "^4.17.0"
   },
-  "optionalDependencies": {
-    "fsevents": "^2.3.3"
-  },
   "devDependencies": {
     "@types/express": "^4.17.21",
     "@types/geojson": "^7946.0.7",
@@ -61,4 +58,4 @@
     "ts-jest": "^26.1.1",
     "typescript": "^4.6.3"
   }
-}
+}

plugins/image/service/package.json

@@ -40,9 +40,6 @@
     "express": "~4.17.0",
     "mongoose": "^6.13.0"
   },
-  "optionalDependencies": {
-    "fsevents": "^2.3.3"
-  },
   "devDependencies": {
     "@types/bson": "^4.0.2",
     "@types/express": "~4.17.17",
@@ -56,4 +53,4 @@
     "rimraf": "^5.0.5",
     "typescript": "^4.9.5"
   }
-}
+}