Skip to content

Commit 545c454

Browse files
committed
[service] add todo comment to address
1 parent 7a667ac commit 545c454

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

service/src/entities/observations/entities.observations.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,17 @@ export interface Attachment {
115115
* store implementation may not use `contentLocator` at all.
116116
*/
117117
contentLocator?: string
118+
/**
119+
* TODO: this needs to allow a more robust value, such as
120+
* `undefined | boolean` or maybe even allow `{ error: string }` so the
121+
* image plugin's unprocessed attachment query can easily find attachments
122+
* that have not yet been touched vs. attachments whose content could not be
123+
* oriented. admins should also be able to easily query for the faulty
124+
* attachments to take corrective action if possible.
125+
*
126+
* also, because this and the `thumbnails` field are specific to the image
127+
* plugin, they should both be moved out of the core domain type.
128+
*/
118129
oriented: boolean
119130
thumbnails: Thumbnail[]
120131
}

0 commit comments

Comments
 (0)