Admin Teams dashboard component upgrade from AngularJS to Angular 14 #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmckomni
requested changes
Jul 29, 2025
Contributor
jmckomni
left a comment
jmckomni
left a comment
There was a problem hiding this comment.
The core of the work is good. I have some feedback on unit tests and one question about error handling
web-app/admin/src/app/admin/admin-teams/admin-dashboard/admin-teams.component.spec.ts
Outdated
Show resolved
Hide resolved
web-app/admin/src/app/admin/admin-teams/admin-dashboard/admin-teams.component.spec.ts
Outdated
Show resolved
Hide resolved
web-app/admin/src/app/admin/admin-teams/admin-dashboard/admin-teams.component.spec.ts
Outdated
Show resolved
Hide resolved
web-app/admin/src/app/admin/admin-teams/admin-dashboard/admin-teams.component.spec.ts
Outdated
Show resolved
Hide resolved
web-app/admin/src/app/admin/admin-teams/admin-team-create/admin-team-create.component.ts
Outdated
Show resolved
Hide resolved
jmckomni
previously approved these changes
Jul 29, 2025
jmckomni
previously approved these changes
Jul 29, 2025
Contributor
So, initial thoughts on seeing this... and this is just a comment. I feel like this UI style is outdated and could be updated pretty quickly and easily. "Search" is really just a filter, it could easily be moved either into the header or footer of the Teams List without much effort. That would allow us to center the list, make it a bit wider so that more information can fit on the screen with thinner rows, overall it would be a lot more user friendly that way. Looking through the rest now |
cwerthomni
reviewed
Aug 1, 2025
web-app/admin/src/app/admin/admin-teams/dashboard/team-dashboard.component.ts
Show resolved
Hide resolved
jmckomni
approved these changes
Aug 4, 2025
cwerthomni
approved these changes
Aug 5, 2025
cwerthomni
added a commit
that referenced
this pull request
Aug 8, 2025
* update prod dockerfile and github actions * Adds User and Form Selection to Filtering Options. Also Fixes the Time Based Filtering. * Add Comments and a New Type * Fix Variables * added CODEOWNERS file. * Fix Errors found by CJ * KMZ importing updated to support image uploads (#298) Improve KMZ file importing where observations with included images are not displayed properly * moved CODEOWNERS to root of project. * Homepage updated for support for smaller screens (#303) * initial commit * fix title styling * updated css names * Publish containers as packages (#304) * update action to deploy container artifact * update yml and action name * Production Container action * update containers and scripts * update dev dockerfile * update dockerfile --------- Co-authored-by: Clinton Werth <[email protected]> * Prod container action (#305) * new docker file and update prod container action * down to one dockerfile --------- Co-authored-by: Clinton Werth <[email protected]> Co-authored-by: Clinton Werth <[email protected]> * changed time format option from '30 seconds' to 'Relative' * updated CODEOWNERS * MOCKUP: Adding support for observations without geometry (#300) Update the Observation logic to add a noGeometry flag. * Admin Teams dashboard component upgrade from AngularJS to Angular 14 (#306) Updates the Teams component to Angular 14 --------- Co-authored-by: Clinton Werth <[email protected]> * authorization component now submits access code when user hits enter. * Initial Commit, ts and html changes * Hook Up Module * fix modules * Remove and Revert * fixes * directive * include module * Pushing latest changes * Final Commit * fix css * Remove DS Store Files * Make HTML Safe Again * unknown device * fix package log * Updates for 6.4.0-beta.2 release (#311) Co-authored-by: Clinton Werth <[email protected]> --------- Co-authored-by: Clinton Werth <[email protected]> Co-authored-by: Ryan Carpenter <[email protected]> Co-authored-by: John McKeever <[email protected]> Co-authored-by: jmckomni <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Clinton Werth <[email protected]> Co-authored-by: MilliannaMiodori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the teams dashboard page for Admins to use modern Angular. It also Converts the new team page into a modal for easier use.