Skip to content

Conversation

@ryanslatten
Copy link
Contributor

@ryanslatten ryanslatten commented Aug 25, 2025

This PR upgrades the User Details page to Angular 14 and also includes design improvements

User Details page:
Screenshot 2025-08-25 at 4 12 29 PM

Delete User modal:
Screenshot 2025-08-25 at 4 13 13 PM

User Events and Teams tables:
Screenshot 2025-08-25 at 4 13 32 PM

Logins component:
Screenshot 2025-08-25 at 4 13 58 PM

Testing steps:
Prerequisites: Have a user that is a member of several events and teams, have a fresh user that isn't a member of anything, have a user that is only a member of an event or team.

  1. Go to the details page of a user that is a member of several events and teams. Verify that they appear in the expected tables and that pagination and search work. You should also be able to click on an event or team to access their details page.
  2. Verify that the User details load correctly (username, display name, email, etc)
  3. Verify that you can disable a user by clicking on the disable user button. Make sure the user is actually disabled by attempting to log in as the user. Then check enabling the user.
  4. Verify that you can delete a user by clicking on the delete user button. May want to use this on a fresh user.
  5. Verify that the logins table works as expected. (Filters work, pagination works, and that the logins are only for that user if on the user details page) The admin dashboard logins table should be checked as well.
  6. Verify that you can edit the user by clicking the 'Edit' button on the top right of the page. The details section should become an inline edit form. Make sure all the fields work as expected.

cwerthomni
cwerthomni previously approved these changes Aug 27, 2025
Copy link
Contributor

@RyCarpenter RyCarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only other comment would be that I think the map icon would look better inline with the user icon.

Copy link
Contributor

@jmckomni jmckomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke testing feedback:

  • Just saw that the "Edit" button on the Users Dashboard doesn't work
  • When removing a user from a list of >{PAGE_SIZE} teams, the page doesn't update correctly. There's a blank spot in the list until you navigate to the next page in the list and back

@ryanslatten
Copy link
Contributor Author

Smoke testing feedback:

  • Just saw that the "Edit" button on the Users Dashboard doesn't work
  • When removing a user from a list of >{PAGE_SIZE} teams, the page doesn't update correctly. There's a blank spot in the list until you navigate to the next page in the list and back

The edit button was removed. Also updated the getEvents endpoint logic to fix the issue with the blank events

@ryanslatten ryanslatten merged commit 2741f76 into develop Sep 3, 2025
8 checks passed
@ryanslatten ryanslatten deleted the feature/user-details-upgrade branch September 3, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants