-
Notifications
You must be signed in to change notification settings - Fork 50
Admin User Details Angular Upgrade #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t/mage-server into team-details-upgrade
…t/mage-server into team-details-upgrade
…to team-details-upgrade
…to team-details-upgrade
…to feature/user-details-upgrade
RyCarpenter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only other comment would be that I think the map icon would look better inline with the user icon.
web-app/admin/src/app/admin/admin-users/user-details/user-details.component.spec.ts
Outdated
Show resolved
Hide resolved
web-app/admin/src/app/admin/admin-users/user-details/user-details.component.spec.ts
Outdated
Show resolved
Hide resolved
jmckomni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke testing feedback:
- Just saw that the "Edit" button on the Users Dashboard doesn't work
- When removing a user from a list of >{PAGE_SIZE} teams, the page doesn't update correctly. There's a blank spot in the list until you navigate to the next page in the list and back
web-app/admin/src/app/admin/admin-users/user-details/user-details.component.spec.ts
Outdated
Show resolved
Hide resolved
The edit button was removed. Also updated the getEvents endpoint logic to fix the issue with the blank events |
This PR upgrades the User Details page to Angular 14 and also includes design improvements
User Details page:

Delete User modal:

User Events and Teams tables:

Logins component:

Testing steps:
Prerequisites: Have a user that is a member of several events and teams, have a fresh user that isn't a member of anything, have a user that is only a member of an event or team.