-
Notifications
You must be signed in to change notification settings - Fork 50
Feature/mage 1633 #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mage 1633 #343
Conversation
This reverts commit 3d7b4d1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Did you push the commits directly to develop by accident? Is that why things were reverted?
paulsolt-ofsw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this feature doesn't work. Neither version exports .csv files. They are some kind of binary file.
When I tested the new code after a npm install, npm run build, and npm start the .csv export is a binary format. Not a .csv
- There is no file extension on the file that I can download.
- It's not obvious when you create an export, that it's finished and you need to go back to the same UI
- The order of which export is hard to understand. It lacks any timestamp or details about the export.
Yeah that's exactly what I did :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. But please do the following for PRs:
- Branch name: "gitlab number - gitlab name"
- Description: add something/anything


No description provided.