Skip to content

Conversation

@jmckomni
Copy link
Contributor

@jmckomni jmckomni commented Nov 5, 2025

No description provided.

Copy link
Contributor

@paulsolt-ofsw paulsolt-ofsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Did you push the commits directly to develop by accident? Is that why things were reverted?

Copy link
Contributor

@paulsolt-ofsw paulsolt-ofsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this feature doesn't work. Neither version exports .csv files. They are some kind of binary file.

When I tested the new code after a npm install, npm run build, and npm start the .csv export is a binary format. Not a .csv

Screenshot 2025-11-05 at 9 58 12 PM
  1. There is no file extension on the file that I can download.
  2. It's not obvious when you create an export, that it's finished and you need to go back to the same UI
  3. The order of which export is hard to understand. It lacks any timestamp or details about the export.
Screenshot 2025-11-05 at 10 05 47 PM

I tried a few options. Still no .csv.
Screenshot 2025-11-05 at 10 06 43 PM

@jmckomni
Copy link
Contributor Author

jmckomni commented Nov 6, 2025

Looks good. Did you push the commits directly to develop by accident? Is that why things were reverted?

Yeah that's exactly what I did :(

Copy link
Contributor

@danbenner-vega danbenner-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But please do the following for PRs:

  • Branch name: "gitlab number - gitlab name"
  • Description: add something/anything

@paulsolt-ofsw
Copy link
Contributor

paulsolt-ofsw commented Nov 10, 2025

Looks good on Chrome.

Screenshot 2025-11-10 at 6 18 57 PM

@jmckomni jmckomni merged commit 9eb5e40 into develop Nov 12, 2025
6 checks passed
@jmckomni jmckomni deleted the feature/mage-1633 branch November 12, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants