Update Events Dashboard to Angular 14 #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RyCarpenter
commented
Nov 13, 2025
RyCarpenter
commented
The Events Page has been brought into line with the rest of the UI, a few QOL upgrades as well, such as popover tooltips if the description is truncated.
Contributor
The padding above and below the no events found message is a little off. Mind tweaking?
|
Contributor
This modal changes sizes when the error message is present. Can you make it so that it's always a consistent size?
|
jmckomni
requested changes
Nov 13, 2025
web-app/admin/src/app/admin/admin-event/create-event/create-event.component.ts
Outdated
Show resolved
Hide resolved
web-app/admin/src/app/admin/admin-event/dashboard/event-dashboard.component.ts
Outdated
Show resolved
Hide resolved
jmckomni
previously approved these changes
Nov 18, 2025
Contributor
|
I don't think its a good idea for the Users, Teams, and Events tables to have slightly different css designs. We should try to make them consistent. Things like the the table header height different and the rows all have different structures. Events Users Teams We should settle on a single design that we think is best and apply it to all the tables. Ideally they should share the same components and stylesheets |
ryanslatten
previously approved these changes
Nov 19, 2025
ryanslatten
approved these changes
Nov 19, 2025
jmckomni
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.