SIDD: incorrect FDT value

[pressler-vsc]

Some SARPy-produced SIDDs appear to have incorrect FDT (File Date and Time) values in their NITF/JBP file header.

Using v1.3.61:

$ python -m sarpy.utils.create_product /host_shared/sarpy_test/sicd/sicd_example_1_PFA_RE32F_IM32F_HH.nitf .
WARNING:sarpy.io.general.nitf_elements.base:Got string input value of length 89 for attribute FTITLE of class NITFHeader, which is longer than the allowed length 80, so truncating
WARNING:sarpy.io.general.nitf_elements.base:Got string input value of length 89 for attribute IID2 of class ImageSegmentHeader, which is longer than the allowed length 80, so truncating

$ conda run -n jbpy jbpinfo 20160921f01p0009faradx0613_284_21114HH_000_164107_SL0005R_35N107W_001X___QHH_0101_SPY_IMG.nitf | grep FDT
FDT                     14 @          25 b'20160921164107'

This appears consistent with _get_fdt in sarpy/io/product/sidd that tries to use the CollectionDateTime from the SIDD metadata.

Per JBP-2024.1:

and SIDD v3.0.0 volume 2:

FDT should instead be populated with the file creation time.

[petersontex]

@pressler-vsc Thanks for reporting this. We will take a look at this. Is this new with 1.3.61 or did you also see this issue in 1.3.60?

[pressler-vsc]

I only tried using 1.3.61, but the probable offending code is ~5 years old so I think it is has been around a while.

[petersontex]

Please test this with the new v1.3.62 release candidate.

The code is here: https://github.com/ngageoint/sarpy/releases/tag/v1.3.62rc1

Also available from PyPi (As a full release) here: https://pypi.org/project/sarpy/