Add mutex around updating client in the CommandService

Author: sean-breen

internal/collector/nginxplusreceiver/metadata.yaml

@@ -184,7 +184,7 @@ metrics:
     attributes:
       - nginx.cache.outcome
       - nginx.cache.name
-  nginx.cache.responses:
+  nginx.cache.response.count:
     enabled: true
     description: The total number of responses read from the cache or proxied server.
     sum:

internal/command/command_plugin.go

@@ -184,7 +184,7 @@ func (cp *CommandPlugin) processConnectionReset(ctx context.Context, msg *bus.Me
 		}
 		cp.conn = newConnection
 		cp.commandService.UpdateClient(cp.conn.CommandServiceClient())
-		slog.DebugContext(ctx, "Command plugin: client reset successfully")
+		slog.DebugContext(ctx, "Command service client reset successfully")
 	}
 }
 

internal/command/command_service.go

@@ -47,6 +47,7 @@ type (
 		subscribeClientMutex         sync.Mutex
 		configApplyRequestQueueMutex sync.Mutex
 		resourceMutex                sync.Mutex
+		commandMutex                 sync.Mutex
 	}
 )
 
@@ -253,6 +254,8 @@ func (cs *CommandService) CreateConnection(
 }
 
 func (cs *CommandService) UpdateClient(client mpi.CommandServiceClient) {
+	cs.commandMutex.Lock()
+	defer cs.commandMutex.Unlock()
 	cs.commandServiceClient = client
 }