add unit tests

Author: sean-breen

internal/command/command_plugin.go

@@ -189,8 +189,6 @@ func (cp *CommandPlugin) processConnectionReset(ctx context.Context, msg *bus.Me
 		}
 		cp.conn = newConnection
 		cp.commandService.UpdateClient(cp.conn.CommandServiceClient())
-		//go cp.monitorSubscribeChannel(ctx)
-		//cp.createConnection(ctx, cp.commandService.Resource())
 		slog.DebugContext(ctx, "Command plugin: client reset successfully")
 	}
 }

internal/command/command_plugin_test.go

@@ -143,6 +143,9 @@ func TestCommandPlugin_Process(t *testing.T) {
 	})
 	require.Equal(t, 1, fakeCommandService.UpdateDataPlaneHealthCallCount())
 	require.Equal(t, 1, fakeCommandService.SendDataPlaneResponseCallCount())
+
+	commandPlugin.Process(ctx, &bus.Message{Topic: bus.ConnectionResetTopic, Data: &protos.)
+	require.Equal(t, 1, fakeCommandService.UpdateClientCallCount())
 }
 
 func TestCommandPlugin_monitorSubscribeChannel(t *testing.T) {

internal/command/command_service_test.go

@@ -198,6 +198,20 @@ func TestCommandService_CreateConnection(t *testing.T) {
 	require.NoError(t, err)
 }
 
+func TestCommandService_UpdateClient(t *testing.T) {
+	//ctx := context.Background()
+	commandServiceClient := &v1fakes.FakeCommandServiceClient{}
+
+	commandService := NewCommandService(
+		commandServiceClient,
+		types.AgentConfig(),
+		make(chan *mpi.ManagementPlaneRequest),
+	)
+	assert.False(t, commandService.clientUpdated.Load())
+	commandService.UpdateClient(commandServiceClient)
+	assert.True(t, commandService.clientUpdated.Load())
+}
+
 func TestCommandService_UpdateDataPlaneHealth(t *testing.T) {
 	ctx := context.Background()
 	commandServiceClient := &v1fakes.FakeCommandServiceClient{}

internal/grpc/grpc.go

@@ -41,7 +41,6 @@ type (
 		CommandServiceClient() mpi.CommandServiceClient
 		FileServiceClient() mpi.FileServiceClient
 		Close(ctx context.Context) error
-		Restart(ctx context.Context) (*GrpcConnection, error)
 	}
 
 	GrpcConnection struct {
@@ -132,22 +131,6 @@ func (gc *GrpcConnection) Close(ctx context.Context) error {
 	return nil
 }
 
-func (gc *GrpcConnection) Restart(ctx context.Context) (*GrpcConnection, error) {
-	slog.InfoContext(ctx, "Restarting grpc connection")
-	err := gc.Close(ctx)
-	if err != nil {
-		return nil, err
-	}
-
-	slog.InfoContext(ctx, "Creating grpc connection")
-	newConn, err := NewGrpcConnection(ctx, gc.config)
-	if err != nil {
-		return nil, err
-	}
-
-	return newConn, nil
-}
-
 func (w *wrappedStream) RecvMsg(message any) error {
 	err := w.ClientStream.RecvMsg(message)
 	if err == nil {

internal/grpc/grpcfakes/fake_grpc_connection_interface.go

@@ -120,6 +120,24 @@ func TestWatcher_Info(t *testing.T) {
 	assert.Equal(t, &bus.Info{Name: "watcher"}, watcherPlugin.Info())
 }
 
+func TestWatcher_Process_CredentialUpdatedTopic(t *testing.T) {
+	ctx := context.Background()
+
+	watcherPlugin := NewWatcher(types.AgentConfig())
+
+	messagePipe := busfakes.NewFakeMessagePipe()
+
+	err := watcherPlugin.Init(ctx, messagePipe)
+	require.NoError(t, err)
+
+	message := &bus.Message{
+		Topic: bus.CredentialUpdatedTopic,
+		Data:  nil,
+	}
+
+	watcherPlugin.Process(ctx, message)
+}
+
 func TestWatcher_Process_ConfigApplyRequestTopic(t *testing.T) {
 	ctx := context.Background()
 	data := &mpi.ManagementPlaneRequest{