use correct variable names

Author: sean-breen

.github/actions/configure-goproxy/action.yml

@@ -17,14 +17,14 @@ runs:
       id: configure-goproxy
       shell: bash
       run: |
-        if [[ "${{ secrets.ARTIFACTORY_USER }}" == "" ]] || 
+        if [[ "${{ inputs.user }}" == "" ]] || 
         [[ ${{ github.event.pull_request.head.repo.fork }} ]] ||
         [[ ${{ startsWith(github.head_ref, 'dependabot-')}} ]] ; then
           echo "No Artifactory secrets available - using direct GOPROXY"
           GOPROXY_VALUE="direct"
         else
           echo "Development mode - using dev Artifactory"
-          GOPROXY_VALUE="https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@${{ secrets.ARTIFACTORY_URL }}"
+          GOPROXY_VALUE="https://${{ inputs.user }}:${{ inputs.token }}@${{ secrets.ARTIFACTORY_URL }}"
         fi
         echo "GOPROXY=${GOPROXY_VALUE}" >> $GITHUB_ENV
     

.github/workflows/ci.yml

@@ -20,15 +20,15 @@ permissions:
 
 env:
   NFPM_VERSION: 'v2.35.3'
-  GOPROXY: "https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-dev"
+  GOPROXY: "direct"
 
 jobs:
   proxy-sanity-check:
     name: Proxy Sanity Check
     runs-on: ubuntu-22.04
     if: ${{ !github.event.pull_request.head.repo.fork && !startsWith(github.head_ref, 'dependabot-') }}
     env:
-      GOPROXY: "https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-dev"
+      GOPROXY: "https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@${{ secrets.ARTIFACTORY_URL_DEV }}"
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
@@ -50,6 +50,7 @@ jobs:
         with:
           user: ${{ secrets.ARTIFACTORY_USER }}
           token: ${{ secrets.ARTIFACTORY_TOKEN }}
+          url: ${{ secrets.ARTIFACTORY_URL_DEV }}
       - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
             go-version-file: 'go.mod'
@@ -67,11 +68,11 @@ jobs:
       steps:
           - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
-          - name: Configure GOPROXY
-            uses: ./.github/actions/configure-goproxy
+          - uses: ./.github/actions/configure-goproxy
             with:
               user: ${{ secrets.ARTIFACTORY_USER }}
               token: ${{ secrets.ARTIFACTORY_TOKEN }}
+              url: ${{ secrets.ARTIFACTORY_URL_DEV }}
 
           - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
             with: