PR feedback

Author: aphralG

internal/watcher/instance/nginx_config_parser.go

@@ -139,7 +139,7 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
 					nginxConfigContext.Files = append(nginxConfigContext.Files, rootFiles...)
 				case "ssl_certificate", "proxy_ssl_certificate", "ssl_client_certificate", "ssl_trusted_certificate":
 					sslCertFile := ncp.sslCert(ctx, directive.Args[0], rootDir)
-					if !ncp.checkDuplicate(nginxConfigContext.Files, sslCertFile) {
+					if !ncp.isDuplicateFile(nginxConfigContext.Files, sslCertFile) {
 						nginxConfigContext.Files = append(nginxConfigContext.Files, sslCertFile)
 					}
 
@@ -352,7 +352,7 @@ func (ncp *NginxConfigParser) sslCert(ctx context.Context, file, rootDir string)
 	return sslCertFile
 }
 
-func (ncp *NginxConfigParser) checkDuplicate(nginxConfigContextFiles []*mpi.File, newFile *mpi.File) bool {
+func (ncp *NginxConfigParser) isDuplicateFile(nginxConfigContextFiles []*mpi.File, newFile *mpi.File) bool {
 	for _, nginxConfigContextFile := range nginxConfigContextFiles {
 		if nginxConfigContextFile.GetFileMeta().GetName() == newFile.GetFileMeta().GetName() {
 			return true

internal/watcher/instance/nginx_config_parser_test.go

@@ -1046,7 +1046,7 @@ func TestNginxConfigParser_checkDuplicate(t *testing.T) {
 	for _, test := range tests {
 		ncp := NewNginxConfigParser(types.AgentConfig())
 		t.Run(test.name, func(t *testing.T) {
-			assert.Equal(t, test.expected, ncp.checkDuplicate(nginxConfigContextFiles.Files, test.file))
+			assert.Equal(t, test.expected, ncp.isDuplicateFile(nginxConfigContextFiles.Files, test.file))
 		})
 	}
 }