fix: fixing test failures

Author: bejjrajesh

src/plugins/metrics_sender.go

@@ -9,14 +9,16 @@ package plugins
 
 import (
 	"context"
+	"github.com/nginx/agent/sdk/v2"
+	"strings"
+	"sync"
+
 	agent_config "github.com/nginx/agent/sdk/v2/agent/config"
 	"github.com/nginx/agent/sdk/v2/client"
 	"github.com/nginx/agent/sdk/v2/proto"
 	models "github.com/nginx/agent/sdk/v2/proto/events"
 	"github.com/nginx/agent/v2/src/core"
 	"github.com/nginx/agent/v2/src/core/config"
-	"strings"
-	"sync"
 
 	log "github.com/sirupsen/logrus"
 	"go.uber.org/atomic"
@@ -81,14 +83,13 @@ func (r *MetricsSender) Process(msg *core.Message) {
 			log.Warnf("Failed to coerce Message to []Payload: %v", msg.Data())
 			return
 		}
+		defer r.readyToSendMu.RUnlock()
 		for _, p := range payloads {
 			r.readyToSendMu.RLock()
 			if !r.readyToSend.Load() {
 				log.Debugf("metrics_sender is not ready to send the metrics")
-				r.readyToSendMu.RUnlock()
 				continue
 			}
-			r.readyToSendMu.Unlock()
 			switch report := p.(type) {
 			case *proto.MetricsReport:
 				message := client.MessageFromMetrics(report)

src/plugins/metrics_sender_test.go

@@ -10,11 +10,12 @@ package plugins
 import (
 	"context"
 	"errors"
-	"github.com/nginx/agent/v2/src/core/config"
 	"reflect"
 	"testing"
 	"time"
 
+	"github.com/nginx/agent/v2/src/core/config"
+
 	"github.com/nginx/agent/sdk/v2/backoff"
 	"github.com/nginx/agent/sdk/v2/proto"
 	"github.com/nginx/agent/v2/src/core"

test/component/nginx-app-protect/monitoring/monitoring_test.go

@@ -130,7 +130,7 @@ func TestNAPMonitoring(t *testing.T) {
 		return
 	}
 
-	metricsSender := plugins.NewMetricsSender(reporter)
+	metricsSender := plugins.NewMetricsSender(reporter, &config.Config{ClientID: "12345", Features: []string{"metrics-sender"}})
 
 	env := tutils.NewMockEnvironment()
 	env.On("NewHostInfo", testifyMock.Anything, testifyMock.Anything, testifyMock.Anything).Return(&sdkPb.HostInfo{