Ensure stream closure (#1527)

aphralG · web-flow · commit 2ef9720f1924 · 2026-02-19T16:20:05.000Z
diff --git a/internal/file/file_service_operator.go b/internal/file/file_service_operator.go
@@ -539,7 +539,11 @@ func (fso *FileServiceOperator) sendFileUpdateStreamChunks(
 		chunkID++
 	}
 
-	return nil
+	// Ensure the stream is closed and wait for the server's response only
+	// after all chunks are sent
+	_, err = updateFileStreamClient.CloseAndRecv()
+
+	return err
 }
 
 func (fso *FileServiceOperator) sendFileUpdateStreamChunk(
diff --git a/test/mock/grpc/mock_management_file_service.go b/test/mock/grpc/mock_management_file_service.go
@@ -217,6 +217,8 @@ func (mgs *FileService) UpdateFileStream(streamingServer grpc.ClientStreamingSer
 		return writeChunkedFileError
 	}
 
+	streamingServer.SendAndClose(&v1.UpdateFileResponse{})
+
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,11 @@ func (fso *FileServiceOperator) sendFileUpdateStreamChunks(`
`539`	`539`	`chunkID++`
`540`	`540`	`}`
`541`	`541`
`542`		`- return nil`
	`542`	`+ // Ensure the stream is closed and wait for the server's response only`
	`543`	`+ // after all chunks are sent`
	`544`	`+ _, err = updateFileStreamClient.CloseAndRecv()`
	`545`	`+`
	`546`	`+ return err`
`543`	`547`	`}`
`544`	`548`
`545`	`549`	`func (fso *FileServiceOperator) sendFileUpdateStreamChunk(`
Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,8 @@ func (mgs *FileService) UpdateFileStream(streamingServer grpc.ClientStreamingSer`
`217`	`217`	`return writeChunkedFileError`
`218`	`218`	`}`
`219`	`219`
	`220`	`+ streamingServer.SendAndClose(&v1.UpdateFileResponse{})`
	`221`	`+`
`220`	`222`	`return nil`
`221`	`223`	`}`
`222`	`224`