Skip to content

Commit 2f8860a

Browse files
committed
review updates
1 parent 8c3e473 commit 2f8860a

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

internal/file/file_manager_service.go

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -545,28 +545,24 @@ func (fms *FileManagerService) UpdateManifestFile(currentFiles map[string]*mpi.F
545545
manifestFiles := fms.convertToManifestFileMap(currentFiles)
546546
manifestJSON, err := json.MarshalIndent(manifestFiles, "", " ")
547547
if err != nil {
548-
slog.Error("Unable to marshal manifest file json ", "err", err)
549-
return err
548+
return fmt.Errorf("unable to marshal manifest file json: %w", err)
550549
}
551550

552551
// 0755 allows read/execute for all, write for owner
553552
if err = os.MkdirAll(manifestDirPath, dirPerm); err != nil {
554-
slog.Error("Unable to create directory", "err", err)
555-
return err
553+
return fmt.Errorf("unable to create directory %s: %w", manifestDirPath, err)
556554
}
557555

558556
// 0600 ensures only root can read/write
559557
newFile, err := os.OpenFile(manifestFilePath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, filePerm)
560558
if err != nil {
561-
slog.Error("Failed to read manifest file", "error", err)
562-
return err
559+
return fmt.Errorf("failed to read manifest file: %w", err)
563560
}
564561
defer newFile.Close()
565562

566563
_, err = newFile.Write(manifestJSON)
567564
if err != nil {
568-
slog.Error("Failed to write manifest file: %v\n", "error", err)
569-
return err
565+
return fmt.Errorf("failed to write manifest file: %w", err)
570566
}
571567

572568
return nil
@@ -579,16 +575,14 @@ func (fms *FileManagerService) getManifestFile(currentFiles map[string]*mpi.File
579575

580576
file, err := os.ReadFile(manifestFilePath)
581577
if err != nil {
582-
slog.Error("Failed to read manifest file", "error", err)
583-
return nil, err
578+
return nil, fmt.Errorf("failed to read manifest file: %w", err)
584579
}
585580

586581
var manifestFiles map[string]*model.ManifestFile
587582

588583
err = json.Unmarshal(file, &manifestFiles)
589584
if err != nil {
590-
slog.Error("Failed to parse manifest file", "error", err)
591-
return nil, err
585+
return nil, fmt.Errorf("failed to parse manifest file: %w", err)
592586
}
593587

594588
fileMap := fms.convertToFileMap(manifestFiles)

0 commit comments

Comments
 (0)