fix unit tests

Author: aphralG

internal/file/file_manager_service_test.go

@@ -609,7 +609,9 @@ func TestFileManagerService_DetermineFileActions(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(tt *testing.T) {
-			helpers.CreateManifestFileWithErrorCheck(t, manifestDirPath, "manifest.json")
+			// Delete manifest file if it already exists
+			dir := helpers.CreateManifestDirWithErrorCheck(t, manifestDirPath, "manifest.json")
+			manifestFilePath = dir + "manifest.json"
 			fakeFileServiceClient := &v1fakes.FakeFileServiceClient{}
 			fileManagerService := NewFileManagerService(fakeFileServiceClient, types.AgentConfig())
 			err = fileManagerService.UpdateManifestFile(test.currentFiles, true)

internal/file/file_plugin_test.go

@@ -473,3 +473,44 @@ func TestFilePlugin_Process_ConfigApplyRollbackCompleteTopic(t *testing.T) {
 
 	assert.Equal(t, expectedResponse.GetInstanceId(), response.GetInstanceId())
 }
+
+func TestFilePlugin_Process_ConfigApplyCompleteTopic(t *testing.T) {
+	ctx := context.Background()
+	instance := protos.GetNginxOssInstance([]string{})
+	mockFileManager := &filefakes.FakeFileManagerServiceInterface{}
+
+	messagePipe := busfakes.NewFakeMessagePipe()
+	agentConfig := types.AgentConfig()
+	fakeGrpcConnection := &grpcfakes.FakeGrpcConnectionInterface{}
+	filePlugin := NewFilePlugin(agentConfig, fakeGrpcConnection)
+
+	err := filePlugin.Init(ctx, messagePipe)
+	require.NoError(t, err)
+	filePlugin.fileManagerService = mockFileManager
+	expectedResponse := &mpi.DataPlaneResponse{
+		MessageMeta: &mpi.MessageMeta{
+			MessageId:     id.GenerateMessageID(),
+			CorrelationId: "dfsbhj6-bc92-30c1-a9c9-85591422068e",
+			Timestamp:     timestamppb.Now(),
+		},
+		CommandResponse: &mpi.CommandResponse{
+			Status:  mpi.CommandResponse_COMMAND_STATUS_OK,
+			Message: "Config apply successful",
+			Error:   "",
+		},
+		InstanceId: instance.GetInstanceMeta().GetInstanceId(),
+	}
+
+	filePlugin.Process(ctx, &bus.Message{Topic: bus.ConfigApplyCompleteTopic, Data: expectedResponse})
+
+	messages := messagePipe.GetMessages()
+	response, ok := messages[0].Data.(*mpi.DataPlaneResponse)
+	assert.True(t, ok)
+
+	assert.Equal(t, expectedResponse.GetCommandResponse().GetStatus(), response.GetCommandResponse().GetStatus())
+	assert.Equal(t, expectedResponse.GetCommandResponse().GetMessage(), response.GetCommandResponse().GetMessage())
+	assert.Equal(t, expectedResponse.GetCommandResponse().GetError(), response.GetCommandResponse().GetError())
+	assert.Equal(t, expectedResponse.GetMessageMeta().GetCorrelationId(), response.GetMessageMeta().GetCorrelationId())
+
+	assert.Equal(t, expectedResponse.GetInstanceId(), response.GetInstanceId())
+}

test/helpers/os_utils.go

@@ -7,6 +7,7 @@ package helpers
 
 import (
 	"errors"
+	"log/slog"
 	"os"
 	"regexp"
 	"strings"
@@ -37,18 +38,16 @@ func CreateFileWithErrorCheck(t testing.TB, dir, fileName string) *os.File {
 	return testConf
 }
 
-func CreateManifestFileWithErrorCheck(t testing.TB, dir, manifestFileName string) *os.File {
+func CreateManifestDirWithErrorCheck(t testing.TB, dir, manifestFileName string) string {
 	t.Helper()
 
 	if _, err := os.Stat(dir + manifestFileName); !errors.Is(err, os.ErrNotExist) {
+		slog.Info("Manifest file exists, deleting", "", dir+manifestFileName)
 		removeErr := os.Remove(dir + manifestFileName)
 		require.NoError(t, removeErr)
 	}
 
-	testConf, err := os.CreateTemp(dir, manifestFileName)
-	require.NoError(t, err)
-
-	return testConf
+	return os.TempDir()
 }
 
 func RemoveFileWithErrorCheck(t testing.TB, fileName string) {