PR feedback

Author: john-david3

internal/config/config_test.go

@@ -7,13 +7,14 @@ package config
 import (
 	_ "embed"
 	"errors"
-	"fmt"
 	"os"
 	"path"
 	"strings"
 	"testing"
 	"time"
 
+	conf "github.com/nginx/agent/v3/test/config"
+
 	"github.com/nginx/agent/v3/pkg/config"
 
 	"github.com/nginx/agent/v3/test/helpers"
@@ -637,13 +638,6 @@ func TestValidateYamlFile(t *testing.T) {
 	}
 }
 
-//go:embed testdata/nginx-agent-with-token.conf
-var agentConfigWithToken string
-
-func getAgentConfigWithToken(token string) string {
-	return fmt.Sprintf(agentConfigWithToken, token)
-}
-
 func TestResolveExtensions(t *testing.T) {
 	tests := []struct {
 		name     string
@@ -675,7 +669,7 @@ func TestResolveExtensions(t *testing.T) {
 			tempFile := helpers.CreateFileWithErrorCheck(t, tempDir, "nginx-agent.conf")
 			defer helpers.RemoveFileWithErrorCheck(t, tempFile.Name())
 
-			confContent := []byte(getAgentConfigWithToken(tt.input))
+			confContent := []byte(conf.GetAgentConfigWithToken(tt.input))
 			_, writeErr := tempFile.Write(confContent)
 			require.NoError(t, writeErr)
 

…fig/testdata/nginx-agent-with-token.conf …config/agent/nginx-agent-with-token.confinternal/config/testdata/nginx-agent-with-token.conf renamed to test/config/agent/nginx-agent-with-token.conf internal/config/testdata/nginx-agent-with-token.conf renamed to test/config/agent/nginx-agent-with-token.conf

@@ -25,6 +25,9 @@ var embedNginxConfWithMultipleSSLCerts string
 //go:embed nginx/nginx-ssl-certs-with-variables.conf
 var embedNginxConfWithSSLCertsWithVariables string
 
+//go:embed agent/nginx-agent-with-token.conf
+var agentConfigWithToken string
+
 func GetNginxConfigWithMultipleAccessLogs(
 	errorLogName,
 	accessLogName,
@@ -55,3 +58,7 @@ func GetNginxConfigWithSSLCerts(errorLogFile, accessLogFile, certFile string) st
 func GetNginxConfigWithMultipleSSLCerts(errorLogFile, accessLogFile, certFile1, certFile2 string) string {
 	return fmt.Sprintf(embedNginxConfWithMultipleSSLCerts, errorLogFile, accessLogFile, certFile1, certFile2)
 }
+
+func GetAgentConfigWithToken(token string) string {
+	return fmt.Sprintf(agentConfigWithToken, token)
+}