fix test

Author: aphralG

internal/watcher/health/health_watcher_service.go

@@ -51,14 +51,28 @@ func NewHealthWatcherService(agentConfig *config.Config) *HealthWatcherService {
 	}
 }
 
-func (hw *HealthWatcherService) UpdateHealthWatcher(instances []*mpi.Instance) {
+func (hw *HealthWatcherService) UpdateHealthWatcher(ctx context.Context, instances []*mpi.Instance) {
 	hw.healthWatcherMutex.Lock()
 	defer hw.healthWatcherMutex.Unlock()
 
 	clear(hw.instances)
 
 	for _, instance := range instances {
-		hw.instances[instance.GetInstanceMeta().GetInstanceId()] = instance
+		switch instance.GetInstanceMeta().GetInstanceType() {
+		case mpi.InstanceMeta_INSTANCE_TYPE_NGINX, mpi.InstanceMeta_INSTANCE_TYPE_NGINX_PLUS:
+			hw.instances[instance.GetInstanceMeta().GetInstanceId()] = instance
+		case mpi.InstanceMeta_INSTANCE_TYPE_AGENT:
+		case mpi.InstanceMeta_INSTANCE_TYPE_UNSPECIFIED,
+			mpi.InstanceMeta_INSTANCE_TYPE_UNIT,
+			mpi.InstanceMeta_INSTANCE_TYPE_NGINX_APP_PROTECT:
+			fallthrough
+		default:
+			slog.DebugContext(
+				ctx,
+				"Health watcher not implemented",
+				"instance_type", instance.GetInstanceMeta().GetInstanceType(),
+			)
+		}
 	}
 }
 

internal/watcher/health/health_watcher_service_test.go

@@ -55,7 +55,7 @@ func TestHealthWatcherService_UpdateHealthWatcher(t *testing.T) {
 
 	assert.Equal(t, instance, healthWatcher.instances[instance.GetInstanceMeta().GetInstanceId()])
 
-	healthWatcher.UpdateHealthWatcher([]*mpi.Instance{updatedInstance})
+	healthWatcher.UpdateHealthWatcher(t.Context(), []*mpi.Instance{updatedInstance})
 	assert.Equal(t, updatedInstance, healthWatcher.instances[instance.GetInstanceMeta().GetInstanceId()])
 }
 

internal/watcher/watcher_plugin.go

@@ -303,7 +303,7 @@ func (w *Watcher) handleCredentialUpdate(ctx context.Context, message credential
 func (w *Watcher) handleInstanceUpdates(newCtx context.Context, message instance.ResourceUpdatesMessage) {
 	if message.Resource != nil {
 		slog.DebugContext(newCtx, "Resource updated", "resource", message.Resource)
-		w.healthWatcherService.UpdateHealthWatcher(message.Resource.GetInstances())
+		w.healthWatcherService.UpdateHealthWatcher(newCtx, message.Resource.GetInstances())
 
 		w.messagePipe.Process(newCtx, &bus.Message{Topic: bus.ResourceUpdateTopic, Data: message.Resource})
 	}