expand test coverage

Author: aphralG

internal/file/file_manager_service_test.go

@@ -284,7 +284,6 @@ func TestFileManagerService_ConfigApply_Failed(t *testing.T) {
 	require.Error(t, err)
 	assert.Equal(t, model.RollbackRequired, writeStatus)
 	assert.False(t, fileManagerService.rollbackManifest)
-
 }
 
 func TestFileManagerService_checkAllowedDirectory(t *testing.T) {
@@ -658,12 +657,12 @@ func TestFileManagerService_UpdateManifestFile(t *testing.T) {
 	fileHash := files.GenerateHash(fileContent)
 
 	tests := []struct {
-		name                 string
 		currentFiles         map[string]*mpi.File
-		referenced           bool
-		previousRefrenced    bool
-		expectedFiles        map[string]*model.ManifestFile
 		currentManifestFiles map[string]*model.ManifestFile
+		expectedFiles        map[string]*model.ManifestFile
+		name                 string
+		referenced           bool
+		previousReferenced   bool
 	}{
 		{
 			name: "Test 1: Manifest file empty",
@@ -674,17 +673,17 @@ func TestFileManagerService_UpdateManifestFile(t *testing.T) {
 			},
 			expectedFiles: map[string]*model.ManifestFile{
 				"/etc/nginx/nginx.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/nginx.conf",
 						Hash:       fileHash,
 						Size:       0,
 						Referenced: true,
 					},
 				},
 			},
-			currentManifestFiles: map[string]*model.ManifestFile{},
+			currentManifestFiles: make(map[string]*model.ManifestFile),
 			referenced:           true,
-			previousRefrenced:    true,
+			previousReferenced:   true,
 		},
 		{
 			name: "Test 2: Manifest file populated - unreferenced",
@@ -698,15 +697,15 @@ func TestFileManagerService_UpdateManifestFile(t *testing.T) {
 			},
 			expectedFiles: map[string]*model.ManifestFile{
 				"/etc/nginx/nginx.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/nginx.conf",
 						Hash:       fileHash,
 						Size:       0,
 						Referenced: false,
 					},
 				},
 				"/etc/nginx/unref.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/unref.conf",
 						Hash:       fileHash,
 						Size:       0,
@@ -716,16 +715,16 @@ func TestFileManagerService_UpdateManifestFile(t *testing.T) {
 			},
 			currentManifestFiles: map[string]*model.ManifestFile{
 				"/etc/nginx/nginx.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/nginx.conf",
 						Hash:       fileHash,
 						Size:       0,
 						Referenced: true,
 					},
 				},
 			},
-			referenced:        false,
-			previousRefrenced: true,
+			referenced:         false,
+			previousReferenced: true,
 		},
 		{
 			name: "Test 3: Manifest file populated - referenced",
@@ -739,23 +738,23 @@ func TestFileManagerService_UpdateManifestFile(t *testing.T) {
 			},
 			expectedFiles: map[string]*model.ManifestFile{
 				"/etc/nginx/nginx.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/nginx.conf",
 						Hash:       fileHash,
 						Size:       0,
 						Referenced: true,
 					},
 				},
 				"/etc/nginx/test.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/test.conf",
 						Hash:       fileHash,
 						Size:       0,
 						Referenced: true,
 					},
 				},
 				"/etc/nginx/unref.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/unref.conf",
 						Hash:       fileHash,
 						Size:       0,
@@ -765,24 +764,24 @@ func TestFileManagerService_UpdateManifestFile(t *testing.T) {
 			},
 			currentManifestFiles: map[string]*model.ManifestFile{
 				"/etc/nginx/nginx.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/nginx.conf",
 						Hash:       fileHash,
 						Size:       0,
 						Referenced: false,
 					},
 				},
 				"/etc/nginx/unref.conf": {
-					&model.ManifestFileMeta{
+					ManifestFileMeta: &model.ManifestFileMeta{
 						Name:       "/etc/nginx/unref.conf",
 						Hash:       fileHash,
 						Size:       0,
 						Referenced: false,
 					},
 				},
 			},
-			referenced:        true,
-			previousRefrenced: false,
+			referenced:         true,
+			previousReferenced: false,
 		},
 	}