PR feedback

Author: aphralG

internal/datasource/config/nginx_config_parser.go

@@ -177,7 +177,7 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
 				case "app_protect_security_log":
 					if len(directive.Args) > 1 {
 						napEnabled = true
-						sysLogServer := ncp.findValidSysLogServers(directive.Args[1])
+						sysLogServer := ncp.findLocalSysLogServers(directive.Args[1])
 						if sysLogServer != "" && !napSyslogServersFound[sysLogServer] {
 							napSyslogServersFound[sysLogServer] = true
 							slog.DebugContext(ctx, "Found NAP syslog server", "address", sysLogServer)
@@ -203,7 +203,7 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
 		}
 
 		if len(napSyslogServersFound) > 0 {
-			syslogServer := ncp.parseSyslogDirective(ctx, napSyslogServersFound)
+			syslogServer := ncp.findAvailableSyslogServers(ctx, napSyslogServersFound)
 			if syslogServer != "" {
 				nginxConfigContext.NAPSysLogServer = syslogServer
 				ncp.previousNAPSysLogServer = syslogServer
@@ -224,7 +224,7 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
 	return nginxConfigContext, nil
 }
 
-func (ncp *NginxConfigParser) parseSyslogDirective(ctx context.Context, napSyslogServers map[string]bool) string {
+func (ncp *NginxConfigParser) findAvailableSyslogServers(ctx context.Context, napSyslogServers map[string]bool) string {
 	if ncp.previousNAPSysLogServer != "" {
 		if _, ok := napSyslogServers[ncp.previousNAPSysLogServer]; ok {
 			return ncp.previousNAPSysLogServer
@@ -249,7 +249,7 @@ func (ncp *NginxConfigParser) parseSyslogDirective(ctx context.Context, napSyslo
 	return ""
 }
 
-func (ncp *NginxConfigParser) findValidSysLogServers(sysLogServer string) string {
+func (ncp *NginxConfigParser) findLocalSysLogServers(sysLogServer string) string {
 	re := regexp.MustCompile(`syslog:server=([\S]+)`)
 	matches := re.FindStringSubmatch(sysLogServer)
 	if len(matches) > 1 {

internal/datasource/config/nginx_config_parser_test.go

@@ -719,7 +719,7 @@ func TestNginxConfigParser_findValidSysLogServers(t *testing.T) {
 	ncp := NewNginxConfigParser(types.AgentConfig())
 
 	for i, server := range servers {
-		result := ncp.findValidSysLogServers(server)
+		result := ncp.findLocalSysLogServers(server)
 
 		assert.Equal(t, expected[i], result)
 	}