Rename bytes to bytes_read for read cache

Author: CVanF5

internal/collector/nginxplusreceiver/documentation.md

@@ -12,7 +12,7 @@ metrics:
     enabled: false
 ```
 
-### nginx.cache.bytes
+### nginx.cache.bytes_read
 
 The total number of bytes read from the cache or proxied server.
 

internal/collector/nginxplusreceiver/internal/metadata/generated_config.go

@@ -1,7 +1,7 @@
 default:
 all_set:
   metrics:
-    nginx.cache.bytes:
+    nginx.cache.bytes_read:
       enabled: true
     nginx.cache.memory.limit:
       enabled: true
@@ -124,7 +124,7 @@ all_set:
       enabled: true
 none_set:
   metrics:
-    nginx.cache.bytes:
+    nginx.cache.bytes_read:
       enabled: false
     nginx.cache.memory.limit:
       enabled: false

internal/collector/nginxplusreceiver/internal/metadata/generated_config_test.go

@@ -7,7 +7,7 @@ status:
     beta: [metrics]
   distributions: [contrib]
   codeowners:
-    active: [olli-holmala, oliveromahony, apgralG, dhurley, craigell, sean-breen]
+    active: [apgralG, dhurley, craigell, sean-breen, Rashmiti, CVanF5]
 
 resource_attributes:
   instance.id:
@@ -173,7 +173,7 @@ metrics:
     gauge:
       value_type: int
     unit: "requests"
-  nginx.cache.bytes:
+  nginx.cache.bytes_read:
     enabled: true
     description: The total number of bytes read from the cache or proxied server.
     sum:

internal/collector/nginxplusreceiver/internal/metadata/generated_metrics.go

@@ -917,38 +917,38 @@ func (nps *nginxPlusScraper) recordHTTPLimitMetrics(stats *plusapi.Stats, now pc
 
 func (nps *nginxPlusScraper) recordCacheMetrics(stats *plusapi.Stats, now pcommon.Timestamp) {
 	for name, cache := range stats.Caches {
-		nps.mb.RecordNginxCacheBytesDataPoint(
+		nps.mb.RecordNginxCacheBytesReadDataPoint(
 			now,
 			int64(cache.Bypass.Bytes),
 			metadata.AttributeNginxCacheOutcomeBYPASS,
 			name,
 		)
-		nps.mb.RecordNginxCacheBytesDataPoint(
+		nps.mb.RecordNginxCacheBytesReadDataPoint(
 			now,
 			int64(cache.Expired.Bytes),
 			metadata.AttributeNginxCacheOutcomeEXPIRED,
 			name,
 		)
-		nps.mb.RecordNginxCacheBytesDataPoint(now, int64(cache.Hit.Bytes), metadata.AttributeNginxCacheOutcomeHIT, name)
-		nps.mb.RecordNginxCacheBytesDataPoint(
+		nps.mb.RecordNginxCacheBytesReadDataPoint(now, int64(cache.Hit.Bytes), metadata.AttributeNginxCacheOutcomeHIT, name)
+		nps.mb.RecordNginxCacheBytesReadDataPoint(
 			now,
 			int64(cache.Miss.Bytes),
 			metadata.AttributeNginxCacheOutcomeMISS,
 			name,
 		)
-		nps.mb.RecordNginxCacheBytesDataPoint(
+		nps.mb.RecordNginxCacheBytesReadDataPoint(
 			now,
 			int64(cache.Revalidated.Bytes),
 			metadata.AttributeNginxCacheOutcomeREVALIDATED,
 			name,
 		)
-		nps.mb.RecordNginxCacheBytesDataPoint(
+		nps.mb.RecordNginxCacheBytesReadDataPoint(
 			now,
 			int64(cache.Stale.Bytes),
 			metadata.AttributeNginxCacheOutcomeSTALE,
 			name,
 		)
-		nps.mb.RecordNginxCacheBytesDataPoint(
+		nps.mb.RecordNginxCacheBytesReadDataPoint(
 			now,
 			int64(cache.Updating.Bytes),
 			metadata.AttributeNginxCacheOutcomeUPDATING,

internal/collector/nginxplusreceiver/internal/metadata/generated_metrics_test.go

@@ -300,7 +300,7 @@ resourceMetrics:
               isMonotonic: true
             unit: requests
           - description: The total number of bytes read from the cache or proxied server.
-            name: nginx.cache.bytes
+            name: nginx.cache.bytes_read
             sum:
               aggregationTemporality: 2
               dataPoints: