pr feedback

Author: aphralG

internal/config/config.go

@@ -459,31 +459,31 @@ func registerDataPlaneFlags(fs *flag.FlagSet) {
 			"collection or error monitoring. This includes absolute paths or regex patterns",
 	)
 
-	// Nginx Reload Backoff Flags
+	// NGINX Reload Backoff Flags
 	fs.Duration(
 		NginxReloadBackoffInitialIntervalKey,
 		DefNginxReloadBackoffInitialInterval,
-		"The client backoff initial interval, value in seconds")
+		"The NGINX reload backoff initial interval, value in seconds")
 
 	fs.Duration(
 		NginxReloadBackoffMaxIntervalKey,
 		DefNginxReloadBackoffMaxInterval,
-		"The client backoff max interval, value in seconds")
+		"The NGINX reload backoff max interval, value in seconds")
 
 	fs.Duration(
 		NginxReloadBackoffMaxElapsedTimeKey,
 		DefNginxReloadBackoffMaxElapsedTime,
-		"The client backoff max elapsed time, value in seconds")
+		"The NGINX reload backoff max elapsed time, value in seconds")
 
 	fs.Float64(
 		NginxReloadBackoffRandomizationFactorKey,
 		DefNginxReloadBackoffRandomizationFactor,
-		"The client backoff randomization factor, value float")
+		"The NGINX reload backoff randomization factor, value float")
 
 	fs.Float64(
 		NginxReloadBackoffMultiplierKey,
 		DefNginxReloadBackoffMultiplier,
-		"The client backoff multiplier, value float")
+		"The NGINX reload backoff multiplier, value float")
 }
 
 func registerCommonFlags(fs *flag.FlagSet) {

internal/resource/nginx_instance_operator.go

@@ -63,10 +63,11 @@ func (i *NginxInstanceOperator) Validate(ctx context.Context, instance *mpi.Inst
 func (i *NginxInstanceOperator) Reload(ctx context.Context, instance *mpi.Instance) error {
 	var reloadTime time.Time
 	var errorsFound error
+	pid := instance.GetInstanceRuntime().GetProcessId()
+
 	slog.InfoContext(ctx, "Reloading NGINX PID", "pid",
-		instance.GetInstanceRuntime().GetProcessId())
+		pid)
 
-	pid := instance.GetInstanceRuntime().GetProcessId()
 	workers := i.nginxProcessOperator.NginxWorkerProcesses(ctx, pid)
 
 	if len(workers) > 0 {
@@ -80,7 +81,7 @@ func (i *NginxInstanceOperator) Reload(ctx context.Context, instance *mpi.Instan
 
 	go i.monitorLogs(ctx, errorLogs, logErrorChannel)
 
-	err := i.executer.KillProcess(instance.GetInstanceRuntime().GetProcessId())
+	err := i.executer.KillProcess(pid)
 	if err != nil {
 		return err
 	}
@@ -93,7 +94,7 @@ func (i *NginxInstanceOperator) Reload(ctx context.Context, instance *mpi.Instan
 		i.checkWorkers(ctx, instance.GetInstanceMeta().GetInstanceId(), reloadTime, processes)
 	}
 
-	slog.InfoContext(ctx, "NGINX reloaded", "process_id", instance.GetInstanceRuntime().GetProcessId())
+	slog.InfoContext(ctx, "NGINX reloaded", "process_id", pid)
 
 	numberOfExpectedMessages := len(errorLogs)