PR feedback

Author: aphralG

internal/resource/nginx_plus_actions.go

@@ -45,7 +45,7 @@ func (a *APIAction) HandleUpdateStreamServersRequest(ctx context.Context, action
 		"Successfully updated stream upstream servers", instanceID, "")
 }
 
-func (a *APIAction) HandleGetStreamUpstreams(ctx context.Context, instance *mpi.Instance) *mpi.DataPlaneResponse {
+func (a *APIAction) HandleGetStreamUpstreamsRequest(ctx context.Context, instance *mpi.Instance) *mpi.DataPlaneResponse {
 	correlationID := logger.GetCorrelationID(ctx)
 	instanceID := instance.GetInstanceMeta().GetInstanceId()
 	streamUpstreamsResponse := emptyResponse
@@ -69,7 +69,7 @@ func (a *APIAction) HandleGetStreamUpstreams(ctx context.Context, instance *mpi.
 		streamUpstreamsResponse, instanceID, "")
 }
 
-func (a *APIAction) HandleGetUpstreams(ctx context.Context, instance *mpi.Instance) *mpi.DataPlaneResponse {
+func (a *APIAction) HandleGetUpstreamsRequest(ctx context.Context, instance *mpi.Instance) *mpi.DataPlaneResponse {
 	correlationID := logger.GetCorrelationID(ctx)
 	instanceID := instance.GetInstanceMeta().GetInstanceId()
 	upstreamsResponse := emptyResponse
@@ -94,7 +94,7 @@ func (a *APIAction) HandleGetUpstreams(ctx context.Context, instance *mpi.Instan
 		upstreamsResponse, instanceID, "")
 }
 
-func (a *APIAction) HandleUpdateHTTPUpstreams(ctx context.Context, action *mpi.NGINXPlusAction,
+func (a *APIAction) HandleUpdateHTTPUpstreamsRequest(ctx context.Context, action *mpi.NGINXPlusAction,
 	instance *mpi.Instance,
 ) *mpi.DataPlaneResponse {
 	correlationID := logger.GetCorrelationID(ctx)
@@ -119,7 +119,7 @@ func (a *APIAction) HandleUpdateHTTPUpstreams(ctx context.Context, action *mpi.N
 		"Successfully updated HTTP Upstreams", instanceID, "")
 }
 
-func (a *APIAction) HandleGetHTTPUpstreamsServers(ctx context.Context, action *mpi.NGINXPlusAction,
+func (a *APIAction) HandleGetHTTPUpstreamsServersRequest(ctx context.Context, action *mpi.NGINXPlusAction,
 	instance *mpi.Instance,
 ) *mpi.DataPlaneResponse {
 	correlationID := logger.GetCorrelationID(ctx)

internal/resource/resource_plugin.go

@@ -190,23 +190,23 @@ func (r *Resource) handleNginxPlusActionRequest(ctx context.Context, action *mpi
 	switch action.GetAction().(type) {
 	case *mpi.NGINXPlusAction_UpdateHttpUpstreamServers:
 		slog.DebugContext(ctx, "Updating http upstream servers", "request", action.GetUpdateHttpUpstreamServers())
-		resp := apiAction.HandleUpdateHTTPUpstreams(ctx, action, instance)
+		resp := apiAction.HandleUpdateHTTPUpstreamsRequest(ctx, action, instance)
 		r.messagePipe.Process(ctx, &bus.Message{Topic: bus.DataPlaneResponseTopic, Data: resp})
 	case *mpi.NGINXPlusAction_GetHttpUpstreamServers:
 		slog.DebugContext(ctx, "Getting http upstream servers", "request", action.GetGetHttpUpstreamServers())
-		resp := apiAction.HandleGetHTTPUpstreamsServers(ctx, action, instance)
+		resp := apiAction.HandleGetHTTPUpstreamsServersRequest(ctx, action, instance)
 		r.messagePipe.Process(ctx, &bus.Message{Topic: bus.DataPlaneResponseTopic, Data: resp})
 	case *mpi.NGINXPlusAction_UpdateStreamServers:
 		slog.DebugContext(ctx, "Updating stream servers", "request", action.GetUpdateStreamServers())
 		resp := apiAction.HandleUpdateStreamServersRequest(ctx, action, instance)
 		r.messagePipe.Process(ctx, &bus.Message{Topic: bus.DataPlaneResponseTopic, Data: resp})
 	case *mpi.NGINXPlusAction_GetStreamUpstreams:
 		slog.DebugContext(ctx, "Getting stream upstreams", "request", action.GetGetStreamUpstreams())
-		resp := apiAction.HandleGetStreamUpstreams(ctx, instance)
+		resp := apiAction.HandleGetStreamUpstreamsRequest(ctx, instance)
 		r.messagePipe.Process(ctx, &bus.Message{Topic: bus.DataPlaneResponseTopic, Data: resp})
 	case *mpi.NGINXPlusAction_GetUpstreams:
 		slog.DebugContext(ctx, "Getting upstreams", "request", action.GetGetUpstreams())
-		resp := apiAction.HandleGetUpstreams(ctx, instance)
+		resp := apiAction.HandleGetUpstreamsRequest(ctx, instance)
 		r.messagePipe.Process(ctx, &bus.Message{Topic: bus.DataPlaneResponseTopic, Data: resp})
 	default:
 		slog.DebugContext(ctx, "NGINX Plus action not implemented yet")