Skip to content

Commit ab5b434

Browse files
committed
Handle file close error
1 parent 7579f83 commit ab5b434

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

internal/file/file_manager_service.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ func (fms *FileManagerService) UpdateManifestFile(currentFiles map[string]*mpi.F
846846
return fms.writeManifestFile(updatedFiles)
847847
}
848848

849-
func (fms *FileManagerService) writeManifestFile(updatedFiles map[string]*model.ManifestFile) error {
849+
func (fms *FileManagerService) writeManifestFile(updatedFiles map[string]*model.ManifestFile) (writeError error) {
850850
manifestJSON, err := json.MarshalIndent(updatedFiles, "", " ")
851851
if err != nil {
852852
return fmt.Errorf("unable to marshal manifest file json: %w", err)
@@ -862,14 +862,18 @@ func (fms *FileManagerService) writeManifestFile(updatedFiles map[string]*model.
862862
if err != nil {
863863
return fmt.Errorf("failed to read manifest file: %w", err)
864864
}
865-
defer newFile.Close()
865+
defer func() {
866+
if closeErr := newFile.Close(); closeErr != nil {
867+
writeError = closeErr
868+
}
869+
}()
866870

867871
_, err = newFile.Write(manifestJSON)
868872
if err != nil {
869873
return fmt.Errorf("failed to write manifest file: %w", err)
870874
}
871875

872-
return nil
876+
return writeError
873877
}
874878

875879
func (fms *FileManagerService) manifestFile() (map[string]*model.ManifestFile, map[string]*mpi.File, error) {

0 commit comments

Comments
 (0)