PR feedback

Author: aphralG

internal/collector/otel_collector_plugin.go

@@ -572,7 +572,7 @@ func (oc *Collector) updateNginxAppProtectTcplogReceivers(
 		oc.config.Collector.Receivers.TcplogReceivers = make(map[string]*config.TcplogReceiver)
 	}
 
-	napSysLogServer := oc.findAvailableSyslogServers(ctx, nginxConfigContext.NAPSysLogServer)
+	napSysLogServer := oc.findAvailableSyslogServer(ctx, nginxConfigContext.NAPSysLogServer)
 
 	if napSysLogServer != "" {
 		if !oc.doesTcplogReceiverAlreadyExist(napSysLogServer) {
@@ -705,7 +705,7 @@ func (oc *Collector) updateResourceAttributes(
 	return actionUpdated
 }
 
-func (oc *Collector) findAvailableSyslogServers(ctx context.Context, napSyslogServer string) string {
+func (oc *Collector) findAvailableSyslogServer(ctx context.Context, napSyslogServer string) string {
 	if oc.previousNAPSysLogServer != "" && oc.previousNAPSysLogServer == napSyslogServer {
 		return oc.previousNAPSysLogServer
 	}

internal/collector/otel_collector_plugin_test.go

@@ -988,7 +988,7 @@ func TestCollector_findAvailableSyslogServers(t *testing.T) {
 				defer ln.Close()
 			}
 
-			actual := collector.findAvailableSyslogServers(ctx, test.syslogServers)
+			actual := collector.findAvailableSyslogServer(ctx, test.syslogServers)
 			assert.Equal(tt, test.expectedSyslogServer, actual)
 		})
 	}

internal/config/config.go

@@ -424,7 +424,7 @@ func registerFlags() {
 	fs.String(
 		SyslogServerPort,
 		DefSyslogServerPort,
-		"The port Agent will start the syslog server for Nginx App Protect Security violations on",
+		"The port Agent will start the syslog server on for logs collection",
 	)
 
 	registerCommonFlags(fs)