clean up

Author: aphralG

internal/watcher/health/health_watcher_service_test.go

@@ -186,87 +186,6 @@ func TestHealthWatcherService_health(t *testing.T) {
 	}
 }
 
-//func TestHealthWatcherService_health2(t *testing.T) {
-//	ctx := context.Background()
-//	agentConfig := types.AgentConfig()
-//	healthWatcher := NewHealthWatcherService(agentConfig)
-//	ossInstance := protos.NginxOssInstance([]string{})
-//	plusInstance := protos.NginxPlusInstance([]string{})
-//	unspecifiedInstance := protos.UnsupportedInstance()
-//
-//	fakeOSSHealthOp := healthfakes.FakeHealthWatcherOperator{}
-//	fakeOSSHealthOp.HealthReturns(protos.HealthyInstanceHealth(), nil)
-//
-//	fakePlusHealthOp := healthfakes.FakeHealthWatcherOperator{}
-//	fakePlusHealthOp.HealthReturns(protos.UnhealthyInstanceHealth(), nil)
-//
-//	fakeUnspecifiedHealthOp := healthfakes.FakeHealthWatcherOperator{}
-//	fakeUnspecifiedHealthOp.HealthReturns(nil, errors.New("unable to determine health"))
-//
-//	healthWatcher.watcher = &fakePlusHealthOp
-//
-//	expected := []*mpi.InstanceHealth{
-//		protos.HealthyInstanceHealth(),
-//		protos.UnhealthyInstanceHealth(),
-//		protos.UnspecifiedInstanceHealth(),
-//	}
-//
-//	healthWatcher.UpdateHealthWatcher([]*mpi.Instance{
-//		ossInstance,
-//		plusInstance,
-//		unspecifiedInstance,
-//	})
-//
-//	tests := []struct {
-//		cache        map[string]*mpi.InstanceHealth
-//		name         string
-//		isHealthDiff bool
-//	}{
-//		{
-//			name: "Test 1: Status Changed",
-//			cache: map[string]*mpi.InstanceHealth{
-//				ossInstance.GetInstanceMeta().GetInstanceId(): protos.HealthyInstanceHealth(),
-//				plusInstance.GetInstanceMeta().GetInstanceId(): {
-//					InstanceId:           plusInstance.GetInstanceMeta().GetInstanceId(),
-//					InstanceHealthStatus: mpi.InstanceHealth_INSTANCE_HEALTH_STATUS_HEALTHY,
-//				},
-//				unspecifiedInstance.GetInstanceMeta().GetInstanceId(): protos.UnspecifiedInstanceHealth(),
-//			},
-//			isHealthDiff: true,
-//		},
-//		{
-//			name: "Test 2: Status Not Changed",
-//			cache: map[string]*mpi.InstanceHealth{
-//				ossInstance.GetInstanceMeta().GetInstanceId():         protos.HealthyInstanceHealth(),
-//				plusInstance.GetInstanceMeta().GetInstanceId():        protos.UnhealthyInstanceHealth(),
-//				unspecifiedInstance.GetInstanceMeta().GetInstanceId(): protos.UnspecifiedInstanceHealth(),
-//			},
-//			isHealthDiff: false,
-//		},
-//		{
-//			name: "Test 3: Less Instances",
-//			cache: map[string]*mpi.InstanceHealth{
-//				ossInstance.GetInstanceMeta().GetInstanceId(): {
-//					InstanceId:           ossInstance.GetInstanceMeta().GetInstanceId(),
-//					InstanceHealthStatus: mpi.InstanceHealth_INSTANCE_HEALTH_STATUS_UNHEALTHY,
-//				},
-//				unspecifiedInstance.GetInstanceMeta().GetInstanceId(): protos.UnspecifiedInstanceHealth(),
-//			},
-//			isHealthDiff: true,
-//		},
-//	}
-//
-//	for _, test := range tests {
-//		t.Run(test.name, func(tt *testing.T) {
-//			healthWatcher.updateCache(test.cache)
-//			instanceHealth, healthDiff := healthWatcher.health(ctx)
-//			assert.Equal(t, test.isHealthDiff, healthDiff)
-//
-//			reflect.DeepEqual(instanceHealth, expected)
-//		})
-//	}
-//}
-
 func TestHealthWatcherService_compareCache(t *testing.T) {
 	ossInstance := protos.NginxOssInstance([]string{})
 	plusInstance := protos.NginxPlusInstance([]string{})