Skip to content

Commit cfc9f48

Browse files
authored
Cert common name validation (#992)
* x509 Certificates: CommonName length requirements changed to 0 * remove unnecessary validations + update proto gen * remove debug message to avoid noise in logs
1 parent c3a5b39 commit cfc9f48

File tree

2 files changed

+65
-66
lines changed

2 files changed

+65
-66
lines changed

api/grpc/mpi/v1/files.pb.go

Lines changed: 63 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/grpc/mpi/v1/files.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,10 +272,10 @@ message X509Name {
272272
repeated string postal_code = 7 [(buf.validate.field).repeated.items.string.min_len = 1];
273273

274274
// Serial Number (SN): Unique identifier or serial number.
275-
string serial_number = 8 [(buf.validate.field).string.min_len = 0];
275+
string serial_number = 8;
276276

277277
// Common Name (CN): Typically the person’s or entity's full name.
278-
string common_name = 9 [(buf.validate.field).string.min_len = 1];
278+
string common_name = 9;
279279

280280
// Parsed attributes including any non-standard attributes, as specified in RFC 2253.
281281
// These attributes are parsed but not marshaled by this package.

0 commit comments

Comments
 (0)