worked on PR comments

Author: Akshay2191

internal/config/config.go

@@ -947,7 +947,9 @@ func validateLabel(labelValue string) bool {
 	const maxLength = 256
 	labelPattern := regexp.MustCompile(regexLabelPattern)
 	if len(labelValue) > maxLength || !labelPattern.MatchString(labelValue) {
-		slog.Warn("Label value contains unsupported character ", "label_value", labelValue)
+		slog.Warn("Label value contains unsupported character or exceed maximum length of 256 characters ",
+			"label_value", labelValue)
+
 		return false
 	}
 

internal/config/config_test.go

@@ -1413,51 +1413,56 @@ func createDefaultCollectorConfig() *Collector {
 
 func TestValidateLabel(t *testing.T) {
 	tests := []struct {
-		name      string
-		input     string
-		wantValid bool
+		name     string
+		input    string
+		expected bool
 	}{
 		{
-			name:      "Test 1: Valid label - simple",
-			input:     "label123",
-			wantValid: true,
+			name:     "Test 1: Valid label - simple",
+			input:    "label123",
+			expected: true,
 		},
 		{
-			name:      "Test 2: Valid label - with dash and underscore",
-			input:     "label-123_abc",
-			wantValid: true,
+			name:     "Test 2: Valid label - with dash and underscore",
+			input:    "label-123_abc",
+			expected: true,
 		},
 		{
-			name:      "Test 3: Invalid label - too long",
-			input:     strings.Repeat("a", 257),
-			wantValid: false,
+			name:     "Test 3: Invalid label - too long",
+			input:    strings.Repeat("a", 257),
+			expected: false,
 		},
 		{
-			name:      "Test 4: Invalid label - special char",
-			input:     "label$",
-			wantValid: false,
+			name:     "Test 4: Invalid label - special char",
+			input:    "label$",
+			expected: false,
 		},
 		{
-			name:      "Test 5: Invalid label - starts with dash",
-			input:     "-label",
-			wantValid: false,
+			name:     "Test 5: Invalid label - starts with dash",
+			input:    "-label",
+			expected: false,
 		},
 		{
-			name:      "Test 6: Invalid label - ends with dash",
-			input:     "label-",
-			wantValid: false,
+			name:     "Test 6: Invalid label - ends with dash",
+			input:    "label-",
+			expected: false,
 		},
 		{
-			name:      "Test 7: Invalid label - empty",
-			input:     "",
-			wantValid: false,
+			name:     "Test 7: Invalid label - empty",
+			input:    "",
+			expected: false,
+		},
+		{
+			name:     "Test 8: Invalid label - contains spaces",
+			input:    "label 123",
+			expected: false,
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			got := validateLabel(tt.input)
-			assert.Equal(t, tt.wantValid, got)
+			actual := validateLabel(tt.input)
+			assert.Equal(t, tt.expected, actual)
 		})
 	}
 }