add unit test and refactor

Author: aphralG

internal/config/config.go

@@ -106,10 +106,6 @@ func ResolveConfig() (*Config, error) {
 		return nil, fmt.Errorf("invalid configuration: %w", err)
 	}
 
-	if !viperInstance.IsSet(CollectorLogLevelKey) && strings.ToLower(log.Level) == "debug" {
-		collector.Log.Level = "DEBUG"
-	}
-
 	config := &Config{
 		UUID:               viperInstance.GetString(UUIDKey),
 		Version:            viperInstance.GetString(VersionKey),
@@ -1177,6 +1173,10 @@ func resolveCollectorLog() *Log {
 		Path:  viperInstance.GetString(CollectorLogPathKey),
 	}
 
+	if !viperInstance.IsSet(CollectorLogLevelKey) {
+		log.Level = viperInstance.GetString(LogLevelKey)
+	}
+
 	return log
 }
 

internal/config/config_test.go

@@ -298,6 +298,32 @@ func TestResolveCollector(t *testing.T) {
 	})
 }
 
+func TestResolveCollectorLog(t *testing.T) {
+	t.Run("Test 1: OTel Log Level Set In Config", func(t *testing.T) {
+		viperInstance = viper.NewWithOptions(viper.KeyDelimiter(KeyDelimiter))
+
+		viperInstance.Set(CollectorLogLevelKey, "info")
+		viperInstance.Set(CollectorLogPathKey, "/tmp/collector.log")
+		viperInstance.Set(LogLevelKey, "debug")
+
+		log := resolveCollectorLog()
+
+		// Check
+		assert.Equal(t, "info", log.Level)
+		assert.Equal(t, "/tmp/collector.log", log.Path)
+	})
+
+	t.Run("Test 2: OTel Log Level Not Set In Config", func(t *testing.T) {
+		viperInstance = viper.NewWithOptions(viper.KeyDelimiter(KeyDelimiter))
+		viperInstance.Set(LogLevelKey, "debug")
+		viperInstance.Set(CollectorLogPathKey, "/tmp/collector.log")
+
+		log := resolveCollectorLog()
+		assert.Equal(t, "debug", log.Level)
+		assert.Equal(t, "/tmp/collector.log", log.Path)
+	})
+}
+
 func TestCommand(t *testing.T) {
 	viperInstance = viper.NewWithOptions(viper.KeyDelimiter(KeyDelimiter))
 	expected := agentConfig().Command