use client timeout

Author: aphralG

internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper.go

@@ -59,6 +59,8 @@ func (s *NginxStubStatusScraper) ID() component.ID {
 
 func (s *NginxStubStatusScraper) Start(_ context.Context, _ component.Host) error {
 	httpClient := http.DefaultClient
+	httpClient.Timeout = s.cfg.ClientConfig.Timeout
+
 	if strings.HasPrefix(s.cfg.APIDetails.Listen, "unix:") {
 		httpClient.Transport = &http.Transport{
 			DialContext: func(_ context.Context, _, _ string) (net.Conn, error) {

internal/collector/nginxplusreceiver/scraper.go

@@ -49,7 +49,9 @@ func newNginxPlusScraper(
 	endpoint := strings.TrimPrefix(cfg.APIDetails.URL, "unix:")
 	logger := settings.Logger
 	logger.Info("Creating NGINX Plus scraper")
+
 	httpClient := http.DefaultClient
+	httpClient.Timeout = cfg.ClientConfig.Timeout
 
 	mb := metadata.NewMetricsBuilder(cfg.MetricsBuilderConfig, settings)
 	rb := mb.NewResourceBuilder()

internal/watcher/instance/nginx_config_parser.go

@@ -479,14 +479,14 @@ func (ncp *NginxConfigParser) apiCallback(ctx context.Context, parent,
 func (ncp *NginxConfigParser) pingAPIEndpoint(ctx context.Context, statusAPIDetail *model.APIDetails,
 	apiType string,
 ) bool {
-	httpClient := http.Client{}
+	httpClient := http.DefaultClient
 	listen := statusAPIDetail.Listen
 	statusAPI := statusAPIDetail.URL
 
 	if strings.HasPrefix(listen, "unix:") {
 		httpClient = ncp.SocketClient(strings.TrimPrefix(listen, "unix:"))
 	} else {
-		httpClient = http.Client{Timeout: ncp.agentConfig.Client.Grpc.KeepAlive.Timeout}
+		httpClient.Timeout = ncp.agentConfig.Client.HTTP.Timeout
 	}
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, statusAPI, nil)
 	if err != nil {
@@ -676,8 +676,8 @@ func (ncp *NginxConfigParser) isPort(value string) bool {
 	return err == nil && port >= 1 && port <= 65535
 }
 
-func (ncp *NginxConfigParser) SocketClient(socketPath string) http.Client {
-	return http.Client{
+func (ncp *NginxConfigParser) SocketClient(socketPath string) *http.Client {
+	return &http.Client{
 		Timeout: ncp.agentConfig.Client.Grpc.KeepAlive.Timeout,
 		Transport: &http.Transport{
 			DialContext: func(_ context.Context, _, _ string) (net.Conn, error) {