clean up agent config settings

Author: aphralG

README.md

@@ -24,7 +24,7 @@ The following packages need to be installed:
 ```
 git clone https://github.com/open-telemetry/opentelemetry-collector.git
 cd opentelemetry-collector
-git checkout v0.114.0
+git checkout v0.124.0
 cd cmd/mdatagen
 go install
 ```

internal/collector/nginxossreceiver/metadata.yaml

@@ -7,7 +7,7 @@ status:
     beta: [metrics]
   distributions: [contrib]
   codeowners:
-    active: [aphralG, dhurley, craigell, sean-breen, Rashmiti, CVanF5]
+    active: [ aphralG, dhurley, craigell, sean-breen, CVanF5 ]
 
 resource_attributes:
   instance.id:

internal/collector/nginxplusreceiver/metadata.yaml

@@ -7,7 +7,7 @@ status:
     beta: [metrics]
   distributions: [contrib]
   codeowners:
-    active: [apgralG, dhurley, craigell, sean-breen, Rashmiti, CVanF5]
+    active: [ aphralG, dhurley, craigell, sean-breen, CVanF5 ]
 
 resource_attributes:
   instance.id:

internal/collector/otel_collector_plugin.go

@@ -26,8 +26,9 @@ import (
 )
 
 const (
-	maxTimeToWaitForShutdown = 30 * time.Second
-	filePermission           = 0o600
+	maxTimeToWaitForShutdown  = 30 * time.Second
+	defaultCollectionInterval = 1 * time.Minute
+	filePermission            = 0o600
 	// To conform to the rfc3164 spec the timestamp in the logs need to be formatted correctly.
 	// Here are some examples of what the timestamp conversions look like.
 	// Notice how if the day begins with a zero that the zero is replaced with an empty space.
@@ -405,6 +406,7 @@ func (oc *Collector) checkForNewReceivers(nginxConfigContext *model.NginxConfigC
 					Listen:   nginxConfigContext.PlusAPI.Listen,
 					Location: nginxConfigContext.PlusAPI.Location,
 				},
+				CollectionInterval: defaultCollectionInterval,
 			},
 		)
 
@@ -438,7 +440,8 @@ func (oc *Collector) addNginxOssReceiver(nginxConfigContext *model.NginxConfigCo
 					Listen:   nginxConfigContext.StubStatus.Listen,
 					Location: nginxConfigContext.StubStatus.Location,
 				},
-				AccessLogs: toConfigAccessLog(nginxConfigContext.AccessLogs),
+				AccessLogs:         toConfigAccessLog(nginxConfigContext.AccessLogs),
+				CollectionInterval: defaultCollectionInterval,
 			},
 		)
 

internal/collector/otel_collector_plugin_test.go

@@ -184,6 +184,7 @@ func TestCollector_ProcessNginxConfigUpdateTopic(t *testing.T) {
 							Listen:   "",
 							Location: "",
 						},
+						CollectionInterval: defaultCollectionInterval,
 					},
 				},
 			},
@@ -229,6 +230,7 @@ func TestCollector_ProcessNginxConfigUpdateTopic(t *testing.T) {
 								LogFormat: "$$remote_addr - $$remote_user [$$time_local] \\\"$$request\\\"",
 							},
 						},
+						CollectionInterval: defaultCollectionInterval,
 					},
 				},
 			},

internal/collector/otelcol.tmpl

@@ -75,7 +75,9 @@ receivers:
       url: "{{- .StubStatus.URL -}}"
       listen: "{{- .StubStatus.Listen -}}"
       location: "{{- .StubStatus.Location -}}"
-    collection_interval: 10s
+    {{- if .CollectionInterval }}
+    collection_interval: {{ .CollectionInterval }}
+    {{- end }}
     {{- if gt (len .AccessLogs) 0 }}
     access_logs:
     {{- range .AccessLogs }}
@@ -90,7 +92,9 @@ receivers:
         url: "{{- .PlusAPI.URL -}}"
         listen: "{{- .PlusAPI.Listen -}}"
         location: "{{- .PlusAPI.Location -}}"
-    collection_interval: 10s
+    {{- if .CollectionInterval }}
+    collection_interval: {{ .CollectionInterval }}
+    {{- end }}
 {{- end }}
 {{- range $index, $tcplogReceiver := .Receivers.TcplogReceivers }}
   tcplog/{{$index}}:

internal/collector/settings.go

@@ -91,6 +91,7 @@ func createFile(confPath string) error {
 
 // Generates a OTel Collector config to a file by injecting the Metrics Config to a Go template.
 func writeCollectorConfig(conf *config.Collector) error {
+	slog.Info("Writing collector config")
 	otelcolTemplate, err := template.New(otelTemplatePath).Parse(otelcolTemplate)
 	if err != nil {
 		return err

internal/collector/settings_test.go

@@ -93,6 +93,7 @@ func TestTemplateWrite(t *testing.T) {
 			Location: "",
 			Listen:   "",
 		},
+		CollectionInterval: 30 * time.Second,
 		AccessLogs: []config.AccessLog{
 			{
 				LogFormat: accessLogFormat,

internal/config/config_test.go

@@ -12,6 +12,8 @@ import (
 	"testing"
 	"time"
 
+	"github.com/nginx/agent/v3/pkg/config"
+
 	"github.com/nginx/agent/v3/test/helpers"
 
 	"github.com/stretchr/testify/require"
@@ -882,11 +884,13 @@ func createConfig() *Config {
 								FilePath: "/var/log/nginx/access-custom.conf",
 							},
 						},
+						CollectionInterval: 30 * time.Second,
 					},
 				},
 				NginxPlusReceivers: []NginxPlusReceiver{
 					{
-						InstanceID: "cd7b8911-c2c5-4daf-b311-dbead151d939",
+						InstanceID:         "cd7b8911-c2c5-4daf-b311-dbead151d939",
+						CollectionInterval: 30 * time.Second,
 					},
 				},
 				HostMetrics: &HostMetrics{
@@ -966,5 +970,9 @@ func createConfig() *Config {
 			"label2": "new-value",
 			"label3": 123,
 		},
+		Features: []string{
+			config.FeatureCertificates, config.FeatureFileWatcher, config.FeatureMetrics,
+			config.FeatureAPIAction, config.FeatureLogsNap,
+		},
 	}
 }

internal/config/defaults.go

@@ -44,7 +44,7 @@ const (
 	DefBackoffInitialInterval     = 500 * time.Millisecond
 	DefBackoffRandomizationFactor = 0.5 // the value is 0 <= and < 1
 	DefBackoffMultiplier          = 1.5
-	DefBackoffMaxInterval         = 5 * time.Second
+	DefBackoffMaxInterval         = 10 * time.Minute
 	DefBackoffMaxElapsedTime      = 30 * time.Second
 
 	// Watcher defaults