review comment work

Author: Akshay2191

internal/file/external_file_operator.go

@@ -43,6 +43,7 @@ func (efo *ExternalFileOperator) DownloadExternalFile(ctx context.Context, fileA
 ) error {
 	location := fileAction.File.GetExternalDataSource().GetLocation()
 	permission := fileAction.File.GetFileMeta().GetPermissions()
+	fileName := fileAction.File.GetFileMeta().GetName()
 
 	slog.InfoContext(ctx, "Downloading external file from", "location", location)
 
@@ -54,29 +55,26 @@ func (efo *ExternalFileOperator) DownloadExternalFile(ctx context.Context, fileA
 
 	if downloadErr != nil {
 		updateError = fmt.Errorf("failed to download file %s from %s: %w",
-			fileAction.File.GetFileMeta().GetName(), location, downloadErr)
+			fileName, location, downloadErr)
 
 		return updateError
 	}
 
 	if contentToWrite == nil {
 		slog.DebugContext(ctx, "External file unchanged (304), skipping disk write.",
-			"file", fileAction.File.GetFileMeta().GetName())
+			"file", fileName)
 
 		// preserve previous behavior: mark as unchanged so later rename is skipped
 		fileAction.Action = model.Unchanged
 
 		// persist headers if present
 		if headers.ETag != "" || headers.LastModified != "" {
-			fileName := fileAction.File.GetFileMeta().GetName()
 			efo.fileManagerService.externalFileHeaders[fileName] = headers
 		}
 
 		return nil
 	}
 
-	fileName := fileAction.File.GetFileMeta().GetName()
-
 	// Validate downloaded file type before writing to temp location.
 	if err := efo.validateDownloadedFile(contentToWrite, fileName); err != nil {
 		return fmt.Errorf("downloaded file validation failed for %s: %w", fileName, err)

internal/file/file_manager_service.go

@@ -254,7 +254,7 @@ func (fms *FileManagerService) Rollback(ctx context.Context, instanceID string)
 
 			continue
 		case model.Delete, model.Update, model.ExternalFile:
-			content, err := fms.restoreFiles(fileAction)
+			content, err := fms.restoreFiles(ctx, fileAction)
 			if err != nil {
 				return err
 			}