Skip to content

Add stream file transfer#1002

Merged
dhurley merged 6 commits intonginx:v3from
nginx-nickc:v3-stream
Mar 25, 2025
Merged

Add stream file transfer#1002
dhurley merged 6 commits intonginx:v3from
nginx-nickc:v3-stream

Conversation

@nginx-nickc
Copy link
Contributor

@nginx-nickc nginx-nickc commented Feb 27, 2025

Proposed changes

Added stream data transfer for handle large files. General idea is to add *Stream rpc for existing GetFile and UpdateFile, where the file content is divided into chunks. MP and agent can agree on a size limit to use this stream transfer mechanism. Smaller files may not make sense for this.

Added SendChunkedFile and RecvChunkedFile as implementation.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@nginx-nickc nginx-nickc requested a review from a team as a code owner February 27, 2025 17:36
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Feb 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@nginx-nickc
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Mar 6, 2025
@nginx-nickc nginx-nickc changed the title chore: proto def for stream file transfer feat: added stream file transfer Mar 6, 2025
@dhurley dhurley changed the title feat: added stream file transfer Add stream file transfer Mar 13, 2025
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Just have some minor comments around the error messages

@dhurley dhurley merged commit 50853fc into nginx:v3 Mar 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants