Do not send UpdateOverview after handling a Config Update#1082
Closed
CodeMonkeyF5 wants to merge 1 commit intonginx:v3from
Closed
Do not send UpdateOverview after handling a Config Update#1082CodeMonkeyF5 wants to merge 1 commit intonginx:v3from
CodeMonkeyF5 wants to merge 1 commit intonginx:v3from
Conversation
Fixes race condition where config not yet stored in N1 receives Agent V3 update (for what it just applied) resulting in new config version being created.
Author
|
I have hereby read the F5 CLA and agree to its terms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary UpdateOverview as N1 doesn't need to be notified by Agent V3 for an update it just applied.
Proposed changes
Following a Config Update being applied by Agent V3 successfully, there is no need to send a FileOverview update (N1 already knows it and could be in the process of storing it).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)